improved tests

Author: mechelon

src/Endpoints/Block.php

@@ -2,6 +2,7 @@
 
 namespace FiveamCode\LaravelNotionApi\Endpoints;
 
+use FiveamCode\LaravelNotionApi\Exceptions\HandlingException;
 use FiveamCode\LaravelNotionApi\Notion;
 use FiveamCode\LaravelNotionApi\Exceptions\NotionException;
 use FiveamCode\LaravelNotionApi\Entities\Collections\BlockCollection;
@@ -29,15 +30,11 @@ public function children(): BlockCollection
             $this->url(Endpoint::BLOCKS . "/" . $this->blockId . "/children" . "?{$this->buildPaginationQuery()}")
         );
 
-        if ($response->failed())
-            throw NotionException::fromResponse($response);
-
         return new BlockCollection($response->json());
     }
 
     public function create(): array
     {
-        //toDo
-        throw new \Exception("not implemented yet");
+        throw new HandlingException("Not implemented");
     }
 }

src/Endpoints/Pages.php

@@ -3,6 +3,7 @@
 namespace FiveamCode\LaravelNotionApi\Endpoints;
 
 use FiveamCode\LaravelNotionApi\Entities\Page;
+use FiveamCode\LaravelNotionApi\Exceptions\HandlingException;
 use FiveamCode\LaravelNotionApi\Exceptions\NotionException;
 
 class Pages extends Endpoint implements EndpointInterface
@@ -22,22 +23,19 @@ public function find(string $pageId): Page
             $this->url(Endpoint::PAGES . "/" . $pageId)
         );
 
-        if ($response->failed())
-            throw NotionException::fromResponse($response);
-
         return new Page($response->json());
     }
 
     public function create(): array
     {
         //toDo
-        throw new \Exception("not implemented yet");
+        throw new HandlingException("Not implemented");
     }
 
 
     public function updateProperties(): array
     {
         //toDo
-        throw new \Exception("not implemented yet");
+        throw new HandlingException("Not implemented");
     }
 }

src/Endpoints/Users.php

@@ -38,10 +38,6 @@ public function find(string $userId): User
             $this->url(Endpoint::USERS . "/" . $userId)
         );
 
-        if ($response->failed())
-            throw NotionException::fromResponse($response);
-
-
         return new User($response->json());
     }
 }

tests/EndpointBlocksTest.php

@@ -2,6 +2,7 @@
 
 namespace FiveamCode\LaravelNotionApi\Tests;
 
+use FiveamCode\LaravelNotionApi\Exceptions\HandlingException;
 use Illuminate\Support\Facades\Http;
 use FiveamCode\LaravelNotionApi\Entities\Blocks\Block;
 use FiveamCode\LaravelNotionApi\Exceptions\NotionException;
@@ -88,4 +89,13 @@ public function it_throws_a_notion_exception_not_found()
         \Notion::block("b55c9c91-384d-452b-81db-d1ef79372b11")->children();
     }
 
+    /** @test */
+    public function it_throws_a_handling_exception_not_implemented() {
+
+        $this->expectException(HandlingException::class);
+        $this->expectExceptionMessage("Not implemented");
+
+        \Notion::block("")->create();
+    }
+
 }

tests/EndpointPagesTest.php

@@ -4,6 +4,7 @@
 
 use Carbon\Carbon;
 use FiveamCode\LaravelNotionApi\Entities\Page;
+use FiveamCode\LaravelNotionApi\Exceptions\HandlingException;
 use FiveamCode\LaravelNotionApi\Exceptions\NotionException;
 use Illuminate\Support\Facades\Http;
 use Orchestra\Testbench\TestCase;
@@ -86,4 +87,23 @@ public function it_throws_a_notion_exception_not_found()
         \Notion::pages()->find("b55c9c91-384d-452b-81db-d1ef79372b79");
     }
 
+
+    /** @test */
+    public function it_throws_a_handling_exception_not_implemented_for_create() {
+
+        $this->expectException(HandlingException::class);
+        $this->expectExceptionMessage("Not implemented");
+
+        \Notion::pages()->create();
+    }
+
+    /** @test */
+    public function it_throws_a_handling_exception_not_implemented_for_update_properties() {
+
+        $this->expectException(HandlingException::class);
+        $this->expectExceptionMessage("Not implemented");
+
+        \Notion::pages()->updateProperties();
+    }
+
 }

tests/NotionApiTest.php

@@ -2,6 +2,7 @@
 
 namespace FiveamCode\LaravelNotionApi\Tests;
 
+use FiveamCode\LaravelNotionApi\Exceptions\HandlingException;
 use FiveamCode\LaravelNotionApi\Notion;
 use Orchestra\Testbench\TestCase;
 
@@ -37,4 +38,14 @@ public function it_returns_notion_instance_with_set_token_and_connection()
         $this->assertInstanceOf(Notion::class, $notion);
         $this->assertNotEmpty($notion->getConnection());
     }
+
+
+    /** @test */
+    public function it_throws_a_handling_exception_invalid_version()
+    {
+        $this->expectException(HandlingException::class);
+        $this->expectExceptionMessage("invalid version for notion-api");
+
+        $notion = new Notion("secret_*", "v-does-not-exist");
+    }
 }