🐛 Fix zerolog closing the writer passed to it (#658)

<!--
Copyright (C) 2020-2022 Arm Limited or its affiliates and Contributors.
All rights reserved.
SPDX-License-Identifier: Apache-2.0
-->
### Description

<!--
Please add any detail or context that would be useful to a reviewer.
-->



### Test Coverage

<!--
Please put an `x` in the correct box e.g. `[x]` to indicate the testing
coverage of this change.
-->

- [ ]  This change is covered by existing or additional automated tests.
- [ ] Manual testing has been performed (and evidence provided) as
automated testing was not feasible.
- [ ] Additional tests are not required for this change (e.g.
documentation update).

Author: aorabdel

changes/20250729141206.bugfix

@@ -0,0 +1 @@
+:bug: Fix zerolog closing the writer passed to it

utils/logs/writer.go

@@ -41,6 +41,7 @@ func (w *MultipleWritersWithSource) AddWriters(writers ...WriterWithSource) erro
 	}
 	return nil
 }
+
 func (w *MultipleWritersWithSource) Write(p []byte) (n int, err error) {
 	writers, err := w.GetWriters()
 	if err != nil {
@@ -133,12 +134,24 @@ func NewDiodeWriterForSlowWriterWithoutClosing(slowWriter WriterWithSource, ring
 	return newDiodeWriterForSlowWriter(false, slowWriter, ringBufferSize, pollInterval, droppedMessagesLogger)
 }
 
+type nonCloseableWriter struct {
+	io.Writer
+}
+
+func (ncw nonCloseableWriter) Close() error {
+	return nil
+}
+
 func newDiodeWriterForSlowWriter(closeWriterOnClose bool, slowWriter WriterWithSource, ringBufferSize int, pollInterval time.Duration, droppedMessagesLogger Loggers) WriterWithSource {
 	closerStore := parallelisation.NewCloserStore(false)
 	if closeWriterOnClose {
 		closerStore.RegisterCloser(slowWriter)
 	}
-	d := diode.NewWriter(slowWriter, ringBufferSize, pollInterval, func(missed int) {
+
+	// We pass a wrapper that "overrides" the close method to do nothing,
+	// this is because we control the writer's close behaviour through the `closeWriterOnClose` check
+	ncw := nonCloseableWriter{slowWriter}
+	d := diode.NewWriter(ncw, ringBufferSize, pollInterval, func(missed int) {
 		if droppedMessagesLogger != nil {
 			droppedMessagesLogger.LogError(fmt.Sprintf("Logger dropped %d messages", missed))
 		}