Use collection.ParseListWithCleanup in SplitPath function

Author: Kem-Gov

utils/url/url.go

@@ -6,6 +6,7 @@ import (
 	"regexp"
 	"strings"
 
+	"github.com/ARM-software/golang-utils/utils/collection"
 	"github.com/ARM-software/golang-utils/utils/commonerrors"
 	"github.com/ARM-software/golang-utils/utils/reflection"
 )
@@ -143,16 +144,11 @@ func MatchingPathSegments(pathA, pathB string, matcherFn PathSegmentMatcherFunc)
 // SplitPath returns a slice containing the individual segments that make up the path string p.
 // It looks for the default forward slash path separator when splitting.
 func SplitPath(p string) []string {
-	p = strings.TrimSpace(p)
-	if reflection.IsEmpty(p) || p == defaultPathSeparator {
-		return nil
-	}
-
-	p = path.Clean(p)
-	p = strings.Trim(p, defaultPathSeparator)
 	if reflection.IsEmpty(p) {
 		return []string{}
 	}
 
-	return strings.Split(p, defaultPathSeparator)
+	p = path.Clean(p)
+	p = strings.Trim(p, defaultPathSeparator)
+	return collection.ParseListWithCleanup(p, defaultPathSeparator)
 }

utils/url/url_test.go

@@ -412,3 +412,58 @@ func TestUrl_MatchingPathSegments(t *testing.T) {
 		})
 	}
 }
+
+func TestUrl_SplitPath(t *testing.T) {
+	tests := []struct {
+		name   string
+		path   string
+		result []string
+	}{
+		{
+			"empty path",
+			"",
+			[]string{},
+		},
+		{
+			"root path",
+			"/",
+			[]string{"/"},
+		},
+		{
+			"root path with repeated slashes",
+			"///",
+			[]string{"/"},
+		},
+		{
+			"path with one segment",
+			"abc",
+			[]string{"abc"},
+		},
+		{
+			"path with two segments",
+			"abc/123",
+			[]string{"abc", "123"},
+		},
+		{
+			"path with multiple segments",
+			"abc/123/def/456",
+			[]string{"abc", "123", "def", "456"},
+		},
+		{
+			"path with multiple segments including param segment",
+			"abc/123/def/456/zzz/{param1}/999",
+			[]string{"abc", "123", "def", "456", "zzz", "{param1}", "999"},
+		},
+	}
+
+	for i := range tests {
+		test := tests[i]
+		t.Run(test.name, func(t *testing.T) {
+			segments := SplitPath(test.path)
+
+			for i, s := range segments {
+				assert.Equal(t, test.result[i], s)
+			}
+		})
+	}
+}