Merge pull request #1721 from Idclip/explicit_instantiation_windows

Turn off USE_EXPLICIT_INSTANTIATION on Windows by default

Author: Idclip

CMakeLists.txt

@@ -141,9 +141,14 @@ option(OPENVDB_ENABLE_UNINSTALL "Adds a CMake uninstall target." ON)
 option(USE_COLORED_OUTPUT "Always produce ANSI-colored output (GNU/Clang only)." OFF)
 cmake_dependent_option(USE_PKGCONFIG "Use pkg-config to search for dependent libraries." ON "NOT WIN32" OFF)
 
-option(USE_EXPLICIT_INSTANTIATION "Use explicit instantiation for all supported classes and methods against a
-pre-defined list of OpenVDB trees. This makes the core library larger and slower to compile, but speeds up
-the compilation of all dependent code by bypassing the expensive template instantation." ON)
+# Disable this on Windows due to linker OOM issues:
+#  LNK1248: image size (XXX) exceeds maximum allowable size (FFFFFFFF)
+#    https://github.com/AcademySoftwareFoundation/openvdb/issues/1718
+#    https://github.com/AcademySoftwareFoundation/openvdb/issues/1624
+cmake_dependent_option(USE_EXPLICIT_INSTANTIATION "Use explicit instantiation for all supported classes
+and methods against a pre-defined list of OpenVDB trees. This makes the core library larger and slower
+to compile, but speeds up the compilation of all dependent code by bypassing the expensive template
+instantation." ON "NOT WIN32" OFF)
 
 set(SYSTEM_LIBRARY_PATHS "" CACHE STRING [=[
 A global list of library paths to additionally use into when searching for dependencies.]=])

pendingchanges/explicit_inst_win.txt

@@ -0,0 +1,3 @@
+Build:
+    - USE_EXPLICIT_INSTANTIATION is now disabled on Windows by default due to
+    OOM linker issues.