Enabled some more useful compiler warnings around fallthrough switches and missing virtual methods

Signed-off-by: Nick Avramoussis <4256455+Idclip@users.noreply.github.com>

Author: Idclip

cmake/config/OpenVDBCXX.cmake

@@ -178,6 +178,10 @@ if(OPENVDB_CXX_STRICT)
   add_compile_options("$<$<COMPILE_LANG_AND_ID:CXX,Clang,AppleClang>:-Wall>")
   add_compile_options("$<$<COMPILE_LANG_AND_ID:CXX,Clang,AppleClang>:-Wextra>")
   add_compile_options("$<$<COMPILE_LANG_AND_ID:CXX,Clang,AppleClang>:-Wconversion>")
+  add_compile_options("$<$<COMPILE_LANG_AND_ID:CXX,Clang,AppleClang>:-Wnon-virtual-dtor>")
+  add_compile_options("$<$<COMPILE_LANG_AND_ID:CXX,Clang,AppleClang>:-Wover-aligned>")
+  add_compile_options("$<$<COMPILE_LANG_AND_ID:CXX,Clang,AppleClang>:-Wimplicit-fallthrough>")
+  add_compile_options("$<$<AND:$<CXX_COMPILER_ID:GNU>,$<VERSION_GREATER_EQUAL:$<CXX_COMPILER_VERSION>,9.3.0>>:-Wimplicit-fallthrough>")
   # Only check global constructors for libraries (we should really check for
   # executables too but gtest relies on these types of constructors for its
   # framework).
@@ -193,6 +197,7 @@ if(OPENVDB_CXX_STRICT)
   add_compile_options("$<$<COMPILE_LANG_AND_ID:CXX,GNU>:-Wconversion>")
   add_compile_options("$<$<COMPILE_LANG_AND_ID:CXX,GNU>:-Wdisabled-optimization>")
   add_compile_options("$<$<COMPILE_LANG_AND_ID:CXX,GNU>:-Woverloaded-virtual>")
+  add_compile_options("$<$<COMPILE_LANG_AND_ID:CXX,GNU>:-Wnon-virtual-dtor>")
 else()
   # NO OPENVDB_CXX_STRICT, suppress some warnings
   if(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")

openvdb/openvdb/tools/ParticlesToLevelSet.h

@@ -686,7 +686,7 @@ struct ParticlesToLevelSet<SdfGridT, AttributeT, InterrupterT>::Raster
                 const Vec3R Nrml = -V * invSpeed; // inverse normalized direction
                 Vec3R P = P0; // local position of instance
                 Real R = R0, d = 0; // local radius and length of trail
-                for (size_t m = 0; run && d <= speed ; ++m) {
+                while (run && d <= speed) {
                     run = this->makeSphere(P, R, att, acc);
                     P += 0.5 * delta * R * Nrml; // adaptive offset along inverse velocity direction
                     d = (P - P0).length(); // current length of trail

openvdb/openvdb/unittest/TestFindActiveValues.cc

@@ -149,9 +149,9 @@ TEST_F(TestFindActiveValues, testSphere2)
         openvdb::tools::FindActiveValues<openvdb::FloatTree> op(tree);
         auto bbox = openvdb::CoordBBox::createCube(openvdb::Coord(0), 1);
         //openvdb::util::CpuTimer timer("\nInscribed cube (class)");
-        int count = 0;
+        //int count = 0;
         while(op.noActiveValues(bbox)) {
-            ++count;
+            //++count;
             bbox.expand(1);
         }
         //const double t = timer.stop();
@@ -165,10 +165,10 @@ TEST_F(TestFindActiveValues, testSphere2)
     {// find largest inscribed cube in index space containing NO active values
         auto bbox = openvdb::CoordBBox::createCube(openvdb::Coord(0), 1);
         //openvdb::util::CpuTimer timer("\nInscribed cube (func)");
-        int count = 0;
+        //int count = 0;
         while(!openvdb::tools::anyActiveValues(tree, bbox)) {
             bbox.expand(1);
-            ++count;
+            //++count;
         }
         //const double t = timer.stop();
         //std::cerr << "Inscribed bbox = " << bbox << std::endl;

openvdb_cmd/vdb_ax/cli.h

@@ -181,6 +181,7 @@ inline void usage(std::ostream& os,
 struct ParamBase
 {
     ParamBase() = default;
+    virtual ~ParamBase() = default;
     inline const std::vector<const char*>& opts() const { return mOpts; }
     inline const char* doc() const { return mDoc; }
     virtual void init(const char* arg, const uint32_t idx = 0) = 0;
@@ -198,6 +199,12 @@ struct BasicParam
     using CB = std::function<void(T&, const char*)>;
     BasicParam(T&& v) : mValue(std::move(v)) {}
     BasicParam(const T& v) : mValue(v) {}
+
+    BasicParam(const BasicParam&) = default;
+    BasicParam(BasicParam&&) = default;
+    BasicParam& operator=(const BasicParam&) = default;
+    BasicParam& operator=(BasicParam&&) = default;
+
     inline void set(const T& v) { mValue = v; }
     inline T& get() { return mValue; }
     inline const T& get() const { return mValue; }
@@ -212,6 +219,12 @@ struct BasicParam
 template <typename T>
 struct Param : public BasicParam<T>, ParamBase
 {
+    ~Param() override = default;
+    Param(const Param&) = default;
+    Param(Param&&) = default;
+    Param& operator=(const Param&) = default;
+    Param& operator=(Param&&) = default;
+
     // CB1 callback passes the value to store
     // CB2 callback passed the value and the argument provided
     // CB3 callback passed the value, the argument provided and the index to