Merge pull request #1746 from Idclip/tsan_volume_spheres_fix

Fixed a TSAN issue with TBB operators being modified and copied concu…

Author: Idclip

openvdb/openvdb/tools/VolumeToSpheres.h

@@ -549,7 +549,7 @@ class UpdatePoints
     const std::vector<Vec3R>& mPoints;
     std::vector<float>& mDistances;
     std::vector<unsigned char>& mMask;
-    bool mOverlapping;
+    const bool mOverlapping;
     float mRadius;
     int mIndex;
 };
@@ -578,8 +578,8 @@ UpdatePoints::UpdatePoints(UpdatePoints& rhs, tbb::split)
     , mDistances(rhs.mDistances)
     , mMask(rhs.mMask)
     , mOverlapping(rhs.mOverlapping)
-    , mRadius(rhs.mRadius)
-    , mIndex(rhs.mIndex)
+    , mRadius(0.0)
+    , mIndex(0)
 {
 }
 

pendingchanges/tsan_spheres.txt

@@ -0,0 +1,5 @@
+OpenVDB:
+  Bug Fixes:
+    - Fixed a thread sanitizer issue which could cause undefined behaviour
+    in VolumeToSpheres::fillWithSpheres
+    [Reported by Jérémie Dumas]