Fix palette bar visibility when first run with default settings. Fix resizing of nvg surface when palette bar is hidden/shown with openGL

Author: alcomposer

Source/NVGSurface.cpp

@@ -211,8 +211,12 @@ void NVGSurface::updateBufferSize()
 void NVGSurface::timerCallback()
 {
     updateBounds(newBounds);
-    if (getBounds() == newBounds)
+    if (getBounds() == newBounds) {
         stopTimer();
+        // The editor will be full of junk from the buffer, so clear it
+        if (renderThroughImage)
+            editor->repaint();
+    }
 }
 #endif
 
@@ -231,9 +235,15 @@ bool NVGSurface::makeContextActive()
     // No need to make context active with Metal, so just check if we have initialised and return that
     return getView() != nullptr && nvg != nullptr && mnvgDevice(nvg) != nullptr;
 #else
-    if (glContext)
-        return glContext->makeActive();
-    return false;
+    bool ret = false;
+    if (glContext) {
+        ret = glContext->makeActive();
+
+        if (renderThroughImage)
+            updateWindowContextVisibility();
+    }
+
+    return ret;
 #endif
 }
 
@@ -267,6 +277,8 @@ void NVGSurface::updateBounds(Rectangle<int> bounds)
         setBounds(bounds.withWidth(getWidth()));
 
     resizing = true;
+
+    updateWindowContextVisibility();
 #else
     setBounds(bounds);
 #endif
@@ -304,7 +316,7 @@ void NVGSurface::render()
     // Flush message queue before rendering, to make sure all GUIs are up-to-date
     editor->pd->flushMessageQueue();
 
-    if (renderThroughImage) {
+    if (renderThroughImage && !resizing) {
         auto const startTime = Time::getMillisecondCounter();
         if (startTime - lastRenderTime < 32) {
             return; // When rendering through juce::image, limit framerate to 30 fps
@@ -380,6 +392,12 @@ void NVGSurface::render()
 
         if (renderThroughImage) {
             renderFrameToImage(backupRenderImage, invalidArea);
+            if (resizing) {
+                hresize = !hresize;
+                resizing = false;
+            }
+            if (getBounds() != newBounds)
+                startTimerHz(60);
         } else {
             needsBufferSwap = true;
         }

Source/NVGSurface.h

@@ -107,11 +107,11 @@ class NVGSurface final :
 
     void renderFrameToImage(Image& image, Rectangle<int> area);
 
+    void resized() override;
+
 private:
     float calculateRenderScale() const;
 
-    void resized() override;
-
     // Sets the surface context to render through floating window, or inside editor as image
     void updateWindowContextVisibility();
 

Source/Sidebar/Palettes.h

@@ -583,7 +583,18 @@ class Palettes final : public Component
     void settingsChanged(String const& name, var const& value) override
     {
         if (name == "show_palettes") {
-            setVisible(value);
+            auto const settingsTree = SettingsFile::getInstance()->getValueTree();
+            // Check if we have recently opened files
+            if (settingsTree.getChildWithName("RecentlyOpened").getNumChildren() || editor->getCurrentCanvas()) {
+                if (isVisible() != static_cast<bool>(value)) {
+                    setVisible(value);
+
+                    // Update the editor and nvg surface in case we are rendering through image
+                    // So that the editor can correctly set the size of the canvas area
+                    editor->resized();
+                    editor->nvgSurface.resized();
+                }
+            }
         }
         if (name == "centre_sidepanel_buttons") {
             resized();