Skip to content
This repository was archived by the owner on May 1, 2021. It is now read-only.

Commit 3949751

Browse files
AndroidDeveloperLBAndroidDeveloperLB
committed
handled some Lint warnings.
1 parent 5a8a94d commit 3949751

File tree

5 files changed

+71
-25
lines changed

5 files changed

+71
-25
lines changed

‎MaterialStuffLibrary/lint.xml‎

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,9 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<lint>
3-
4-
<issue
5-
id="InlinedApi"
6-
severity="ignore" />
7-
8-
<issue
9-
id="RtlEnabled"
10-
severity="ignore" />
11-
12-
<issue id="SelectableText" >
13-
3+
<issue id="ContentDescription" severity="ignore" />
4+
<issue id="InlinedApi" severity="ignore" />
5+
<issue id="RtlEnabled" severity="ignore" />
6+
<issue id="SelectableText">
147
<ignore path="res/layout/adp_select_dialog_item_material.xml" />
158
</issue>
16-
179
</lint>

‎MaterialStuffLibrary/res/layout/adp_alert_dialog_material.xml‎

Lines changed: 17 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,16 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
3+
xmlns:tools="http://schemas.android.com/tools"
34
android:id="@id/adp_parentPanel"
45
android:layout_width="match_parent"
56
android:layout_height="wrap_content"
6-
android:orientation="vertical">
7+
android:orientation="vertical" >
78

89
<LinearLayout
910
android:id="@id/adp_topPanel"
1011
android:layout_width="match_parent"
1112
android:layout_height="wrap_content"
12-
android:orientation="vertical">
13+
android:orientation="vertical" >
1314

1415
<LinearLayout
1516
android:id="@id/adp_title_template"
@@ -22,12 +23,13 @@
2223
android:paddingLeft="@dimen/adp_mtrl_alert_dialog_padding"
2324
android:paddingRight="@dimen/adp_mtrl_alert_dialog_padding"
2425
android:paddingStart="@dimen/adp_mtrl_alert_dialog_padding"
25-
android:paddingTop="@dimen/adp_mtrl_alert_dialog_padding_top">
26+
android:paddingTop="@dimen/adp_mtrl_alert_dialog_padding_top" >
2627

2728
<ImageView
2829
android:id="@id/adp_icon"
2930
android:layout_width="32dip"
3031
android:layout_height="32dip"
32+
android:layout_marginEnd="8dip"
3133
android:layout_marginRight="8dip"
3234
android:scaleType="fitCenter"
3335
android:src="@null" />
@@ -40,7 +42,9 @@
4042
android:ellipsize="end"
4143
android:gravity="start"
4244
android:singleLine="true"
43-
android:textAlignment="viewStart" />
45+
android:textAlignment="viewStart"
46+
tools:ignore="UnusedAttribute" />
47+
4448
</LinearLayout>
4549
<!-- If the client uses a customTitle, it will be added here. -->
4650
</LinearLayout>
@@ -51,23 +55,24 @@
5155
android:layout_height="wrap_content"
5256
android:layout_weight="1"
5357
android:minHeight="48dp"
54-
android:orientation="vertical">
58+
android:orientation="vertical" >
5559

5660
<ScrollView
5761
android:id="@id/adp_scrollView"
5862
android:layout_width="match_parent"
5963
android:layout_height="wrap_content"
60-
android:clipToPadding="false">
64+
android:clipToPadding="false"
65+
tools:ignore="UselessParent" >
6166

6267
<LinearLayout
6368
android:layout_width="match_parent"
6469
android:layout_height="wrap_content"
65-
android:orientation="vertical">
70+
android:orientation="vertical" >
6671

6772
<TextView
6873
android:id="@id/adp_message"
6974
style="?attr/adpMessageTextAppearance"
70-
android:layout_width="match_parent"
75+
android:layout_width="match_parent" android:textIsSelectable="true"
7176
android:layout_height="wrap_content"
7277
android:paddingLeft="@dimen/adp_mtrl_alert_dialog_padding"
7378
android:paddingRight="@dimen/adp_mtrl_alert_dialog_padding"
@@ -87,7 +92,7 @@
8792
android:layout_width="match_parent"
8893
android:layout_height="wrap_content"
8994
android:layout_weight="1"
90-
android:minHeight="48dp">
95+
android:minHeight="48dp" >
9196

9297
<FrameLayout
9398
android:id="@id/adp_custom"
@@ -107,7 +112,8 @@
107112
android:paddingLeft="12dp"
108113
android:paddingRight="12dp"
109114
android:paddingStart="12dp"
110-
android:paddingTop="8dp">
115+
android:paddingTop="8dp"
116+
tools:ignore="UnusedAttribute" >
111117

112118
<Button
113119
android:id="@id/adp_button3"
@@ -134,4 +140,4 @@
134140
android:layout_height="wrap_content" />
135141
</LinearLayout>
136142

137-
</LinearLayout>
143+
</LinearLayout>

‎MaterialStuffLibrary/res/layout/adp_select_dialog_material.xml‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<view xmlns:android="http://schemas.android.com/apk/res/android"
3+
xmlns:tools="http://schemas.android.com/tools"
34
android:id="@id/adp_select_dialog_listview"
4-
class="com.alertdialogpro.internal.AlertController$RecycleListView"
55
android:layout_width="match_parent"
66
android:layout_height="match_parent"
7+
class="com.alertdialogpro.internal.AlertController$RecycleListView"
78
android:cacheColorHint="@null"
89
android:divider="?attr/adpListDivider"
910
android:gravity="start"
1011
android:overScrollMode="ifContentScrolls"
1112
android:scrollbars="vertical"
12-
android:textAlignment="viewStart" />
13+
android:textAlignment="viewStart"
14+
tools:ignore="UnusedAttribute" />

‎MaterialStuffLibrary/res/values-v11/adp_core_themes.xml‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
<resources>
2+
3+
<style name="BaseAdp" parent="Theme.AppCompat.Dialog">
4+
<item name="android:windowMinWidthMajor">@android:dimen/dialog_min_width_major</item>
5+
<item name="android:windowMinWidthMinor">@android:dimen/dialog_min_width_minor</item>
6+
</style>
7+
8+
<style name="BaseAdp.Light" parent="Theme.AppCompat.Light.Dialog">
9+
<item name="android:windowMinWidthMajor">@android:dimen/dialog_min_width_major</item>
10+
<item name="android:windowMinWidthMinor">@android:dimen/dialog_min_width_minor</item>
11+
</style>
12+
13+
</resources>

‎MaterialStuffLibrary/res/values/adp_core_styles.xml‎

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<resources>
3+
4+
<!-- Base text appearance for AlertDialogPro -->
5+
<style name="TextAppearance.AlertDialogPro" parent="android:TextAppearance" />
6+
7+
<!-- Base text appearance for title of AlertDialogPro -->
8+
<style name="TextAppearance.AlertDialogPro.DialogWindowTitle">
9+
<item name="android:textSize">18sp</item>
10+
</style>
11+
12+
<!-- Base style for widget of AlertDialogPro -->
13+
<style name="Widget.AlertDialogPro" parent="android:Widget" />
14+
15+
<!-- Base style for AlertDialogPro -->
16+
<style name="AlertDialogPro">
17+
<!-- The core library has no default style -->
18+
<item name="adpLayout">@null</item>
19+
<item name="adpListLayout">@null</item>
20+
<item name="adpListItemLayout">@null</item>
21+
<item name="adpMultiChoiceItemLayout">@null</item>
22+
<item name="adpSingleChoiceItemLayout">@null</item>
23+
</style>
24+
25+
<!-- Base style for title of AlertDialogPro -->
26+
<style name="DialogWindowTitle.AlertDialogPro" parent="">
27+
<item name="android:maxLines">1</item>
28+
<item name="android:scrollHorizontally">true</item>
29+
<item name="android:textAppearance">@style/TextAppearance.AlertDialogPro.DialogWindowTitle
30+
</item>
31+
</style>
32+
33+
</resources>

0 commit comments

Comments
 (0)