Skip to content

Commit 1c294b2

Browse files
committed
default setting validity when onUpdate is not present
1 parent e9b1786 commit 1c294b2

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

src/settings.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,9 @@ export const DefaultSettings = {
219219
onUpdate(d) {
220220
if (!this.options[d.value]) {
221221
d.isValid = false
222-
d.error = tl('animatedJava.setting.boundingBoxRenderMode.error.invalidOption')
222+
d.error = tl(
223+
'animatedJava.setting.boundingBoxRenderMode.error.invalidOption'
224+
)
223225
}
224226
return d
225227
},
@@ -260,6 +262,8 @@ function evaluateSetting(event, namespace, name, value) {
260262
return handleUpdateDescriptor(
261263
setting.onUpdate(createUpdateDescriptor(setting, value, event))
262264
)
265+
DefaultSettings[namespace][name].isValid = true
266+
DefaultSettings[namespace][name].error = null
263267
return value
264268
} else {
265269
throw new CustomError('Invalid setting path', `${namespace}.${name}`)

src/ui/dialogs/settings.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,7 @@ const RenderTemplates = {
164164
id={`aj.setting.${namespace}.${name}`}
165165
value={value}
166166
onChange={(e) => {
167+
setValue(e.target.value)
167168
try {
168169
settings[namespace][name] = e.target.value
169170
} catch (e) {

0 commit comments

Comments
 (0)