🐛 Fix outliner elements inheriting the same property list

Author: SnaveSutit

src/outliner/resizableOutlinerElement.ts

@@ -1,5 +1,7 @@
+import { fixClassPropertyInheritance } from 'src/util/property'
 import { makeNotZero } from '../util/misc'
 
+@fixClassPropertyInheritance
 export class ResizableOutlinerElement extends OutlinerElement {
 	type = 'resizable'
 	// Properties
@@ -58,13 +60,10 @@ export class ResizableOutlinerElement extends OutlinerElement {
 	}
 
 	extend(data: any) {
-		for (const key in ResizableOutlinerElement.properties) {
-			ResizableOutlinerElement.properties[key].merge(this, data)
+		const properties = this.constructor.properties
+		for (const key in properties) {
+			properties[key]!.merge(this, data)
 		}
-		if (data.visibility !== undefined) {
-			this.visibility = data.visibility
-		}
-
 		return this
 	}
 

src/util/moddingTools.ts

@@ -200,7 +200,6 @@ export function registerProjectMod<ID extends string, RevertContext extends any
 		apply: () => {
 			return [
 				EVENTS.PRE_SELECT_PROJECT.subscribe(project => {
-					console.log('Checking project mod condition for', options.id, project)
 					if (!options.condition(project)) return
 					console.log(`Applying project mod '${options.id}'`)
 					revertContext = options.apply()
@@ -620,8 +619,3 @@ export class ObjectProperty extends Property<'object'> {
 		}
 	}
 }
-
-export const fixClassPropertyInheritance: ClassDecorator = target => {
-	target.properties = { ...target.properties }
-	return target
-}

src/util/property.ts

@@ -0,0 +1,22 @@
+export class DeepClonedObjectProperty extends Property<'object'> {
+	constructor(targetClass: any, name: string, options?: PropertyOptions) {
+		super(targetClass, 'object', name, options)
+	}
+
+	merge(instance: any, data: any) {
+		if (typeof data[this.name] === 'object') {
+			instance[this.name] = JSON.parse(JSON.stringify(data[this.name]))
+		}
+	}
+
+	copy(instance: any, target: any) {
+		if (typeof instance[this.name] === 'object') {
+			target[this.name] = JSON.parse(JSON.stringify(instance[this.name]))
+		}
+	}
+}
+
+export const fixClassPropertyInheritance: ClassDecorator = target => {
+	target.properties = { ...target.properties }
+	return target
+}