update settings.registerPluginSettings to support a seperate display and id keys

Author: IanSSenne

src/animatedJava.ts

@@ -19,14 +19,14 @@ import { intl } from './util/intl'
 import { CustomError } from './util/customError'
 
 const errorMessages = [
-	"Uh oh!",
+	'Uh oh!',
 	"Time to fire up the ol' debugger!",
-	"Your armor stands are sad :(",
-	"Ok, who pushed the big red button?",
+	'Your armor stands are sad :(',
+	'Ok, who pushed the big red button?',
 ]
 
 function getRandomErrorMessage() {
-	const index = Math.round(Math.random() * (errorMessages.length-1))
+	const index = Math.round(Math.random() * (errorMessages.length - 1))
 	return errorMessages[index]
 }
 
@@ -42,14 +42,20 @@ function showUnknownErrorDialog(e: CustomError | any) {
 				id: 'animatedJava.dialogs.miscError',
 				title: tl('animatedJava.dialogs.errors.misc.title'),
 				lines: [
-					tl('animatedJava.dialogs.errors.misc.body', {
-						buildID: process.env.BUILD_ID,
-						errorMessage: e.options ? e.options.message : e.message,
-						randomErrorMessage: getRandomErrorMessage(),
-						errorStack: e.stack,
-						discordLink: process.env.DISCORD_LINK,
-						githubLink: process.env.GITHUB_ISSUES_LINK,
-					}, true),
+					tl(
+						'animatedJava.dialogs.errors.misc.body',
+						{
+							buildID: process.env.BUILD_ID,
+							errorMessage: e.options
+								? e.options.message
+								: e.message,
+							randomErrorMessage: getRandomErrorMessage(),
+							errorStack: e.stack,
+							discordLink: process.env.DISCORD_LINK,
+							githubLink: process.env.GITHUB_ISSUES_LINK,
+						},
+						true
+					),
 				],
 				width: 1024,
 				height: 512,

src/settings.js

@@ -10,7 +10,7 @@ import { tl } from './util/intl'
 const genericEmptyErrorText = tl(
 	'animatedJava.settings.generic.errors.emptyValue'
 )
-
+export let ForeignSettingTranslationKeys = {}
 const UNASSIGNED = Symbol('UNASSIGNED_CACHE')
 export const DefaultSettings = {
 	animatedJava: {
@@ -522,15 +522,16 @@ class Settings {
 		return res
 	}
 
-	registerPluginSettings(pluginName, settings) {
-		DefaultSettings[pluginName] = settings
+	registerPluginSettings(exporterId, exporterSettingsKey, settings) {
+		DefaultSettings[exporterSettingsKey] = settings
+		ForeignSettingTranslationKeys[exporterSettingsKey] = exporterId
 		this.update(
 			{
-				[pluginName]: settings,
+				[exporterSettingsKey]: settings,
 			},
 			true
 		)
-		this.assign(pluginName, Object.keys(settings))
+		this.assign(exporterSettingsKey, Object.keys(settings))
 	}
 
 	toConsumable(target = 'all') {

src/ui/dialogs/settings.js

@@ -2,7 +2,11 @@ import { bus } from '../../util/bus'
 import events from '../../constants/events'
 import React, { useEffect, useRef, useState } from 'react'
 import ReactDom from 'react-dom'
-import { DefaultSettings, settings } from '../../settings'
+import {
+	DefaultSettings,
+	ForeignSettingTranslationKeys,
+	settings,
+} from '../../settings'
 import { tl } from '../../util/intl'
 import { ERROR } from '../../util/errors'
 const dialog = electron.dialog
@@ -462,7 +466,12 @@ const Settings = () => {
 											// SettingsPanel(key, setRevealedIndex, index, revealedIndex, children)
 											<SettingsPanel
 												key={key}
-												name={key}
+												name={
+													ForeignSettingTranslationKeys[
+														key
+													] || key
+												}
+												id={key}
 												childrenSettings={children}
 											/>
 										)
@@ -476,17 +485,17 @@ const Settings = () => {
 	)
 }
 
-function SettingsPanel({ childrenSettings, name, visible }) {
+function SettingsPanel({ childrenSettings, name, visible, id }) {
 	const [shown, setShown] = useState(visible)
 	return (
 		<DropDown visible={shown} onClick={() => setShown(!shown)} name={name}>
 			<ul style={{ marginLeft: '2em' }}>
-				{childrenSettings.map((child, id) => (
+				{childrenSettings.map((child) => (
 					<li key={child}>
 						<SettingInput
-							namespace={name}
+							namespace={id}
 							name={child}
-							template={DefaultSettings[name][child]}
+							template={DefaultSettings[id][child]}
 						></SettingInput>
 					</li>
 				))}