Move to using apsw best practices

Co-authored-by: Audrey Roy Greenfeld <arg@answer.ai>

Author: pydanny

sqlite_minutils/db.py

@@ -12,7 +12,7 @@
 import apsw.ext
 import apsw.bestpractice
 
-# apsw.bestpractice.apply(apsw.bestpractice.connection_enable_foreign_keys)
+apsw.bestpractice.apply(apsw.bestpractice.recommended)
 
 try: from sqlite_dump import iterdump
 except ImportError: iterdump = None
@@ -269,6 +269,7 @@ def __init__(
         self._registered_functions: set = set()
         self.use_counts_table = use_counts_table
         self.strict = strict
+        # self.execute('PRAGMA foreign_keys=on;')
 
 
     def close(self):
@@ -1723,15 +1724,15 @@ def transform(
         ]
         try:
             if pragma_foreign_keys_was_on:
-                self.db.execute("PRAGMA foreign_keys=0;")
+                self.db.execute("PRAGMA foreign_keys=off;")
             for sql in sqls:
                 self.db.execute(sql)
             # Run the foreign_key_check before we commit
             if pragma_foreign_keys_was_on:
                 self.db.execute("PRAGMA foreign_key_check;")
         finally:
             if pragma_foreign_keys_was_on:
-                self.db.execute("PRAGMA foreign_keys=1;")
+                self.db.execute("PRAGMA foreign_keys=on;")
         return self
 
     def transform_sql(

tests/test_transform.py

@@ -2,6 +2,7 @@
 from sqlite_minutils.utils import OperationalError
 from sqlite3 import IntegrityError
 import pytest
+import apsw
 
 
 @pytest.mark.parametrize(
@@ -119,12 +120,12 @@ def tracer(sql, params):
         dogs.transform(**params)
     # If use_pragma_foreign_keys, check that we did the right thing
     if use_pragma_foreign_keys:
-        assert ("PRAGMA foreign_keys=0;", None) in captured
+        assert ("PRAGMA foreign_keys=off;", None) in captured
         assert captured[-2] == ("PRAGMA foreign_key_check;", None)
-        assert captured[-1] == ("PRAGMA foreign_keys=1;", None)
+        assert captured[-1] == ("PRAGMA foreign_keys=on;", None)
     else:
-        assert ("PRAGMA foreign_keys=0;", None) not in captured
-        assert ("PRAGMA foreign_keys=1;", None) not in captured
+        assert ("PRAGMA foreign_keys=off;", None) not in captured
+        assert ("PRAGMA foreign_keys=on;", None) not in captured
 
 
 @pytest.mark.parametrize(
@@ -172,32 +173,25 @@ def tracer(sql, params):
         ),
     ],
 )
-@pytest.mark.parametrize("use_pragma_foreign_keys", [False, True])
 def test_transform_sql_table_with_no_primary_key(
-    fresh_db, params, expected_sql, use_pragma_foreign_keys
+    fresh_db, params, expected_sql
 ):
     captured = []
 
     def tracer(sql, params):
         return captured.append((sql, params))
 
     dogs = fresh_db["dogs"]
-    if use_pragma_foreign_keys:
-        fresh_db.conn.execute("PRAGMA foreign_keys=ON")
     dogs.insert({"id": 1, "name": "Cleo", "age": "5"})
     sql = dogs.transform_sql(**{**params, **{"tmp_suffix": "suffix"}})
     assert sql == expected_sql
     # Check that .transform() runs without exceptions:
     with fresh_db.tracer(tracer):
         dogs.transform(**params)
-    # If use_pragma_foreign_keys, check that we did the right thing
-    if use_pragma_foreign_keys:
-        assert ("PRAGMA foreign_keys=0;", None) in captured
-        assert captured[-2] == ("PRAGMA foreign_key_check;", None)
-        assert captured[-1] == ("PRAGMA foreign_keys=1;", None)
-    else:
-        assert ("PRAGMA foreign_keys=0;", None) not in captured
-        assert ("PRAGMA foreign_keys=1;", None) not in captured
+    # We always use foreign keys
+    assert ("PRAGMA foreign_keys=off;", None) in captured
+    assert captured[-2] == ("PRAGMA foreign_key_check;", None)
+    assert captured[-1] == ("PRAGMA foreign_keys=on;", None)
 
 
 def test_transform_sql_with_no_primary_key_to_primary_key_of_id(fresh_db):
@@ -392,7 +386,7 @@ def test_transform_verify_foreign_keys(fresh_db):
     try:
         fresh_db["authors"].transform(rename={"id": "id2"})
         fresh_db.commit()
-    except IntegrityError:
+    except apsw.ConstraintError:
         fresh_db.rollback()
 
     # This should have rolled us back