Fix memleak

TheAssassin · TheAssassin · commit 428d63d5840e · 2019-03-22T01:20:58.000+01:00
diff --git a/src/appimagetool.c b/src/appimagetool.c
@@ -562,7 +562,9 @@ main (int argc, char *argv[])
     gchar* version_env = getenv("VERSION");
 
     if (guess_update_information) {
-        if (g_find_program_in_path("git")) {
+        char* gitPath = g_find_program_in_path("git");
+
+        if (gitPath != NULL) {
             if (version_env == NULL) {
                 GError* error = NULL;
                 gchar* out = NULL;
@@ -602,6 +604,8 @@ main (int argc, char *argv[])
                 }
             }
         }
+
+        free(gitPath);
     }
     
     if(!((0 == strcmp(sqfs_comp, "gzip")) || (0 ==strcmp(sqfs_comp, "xz"))))

Original file line number	Diff line number	Diff line change
`@@ -562,7 +562,9 @@ main (int argc, char *argv[])`
`562`	`562`	`gchar* version_env = getenv("VERSION");`
`563`	`563`
`564`	`564`	`if (guess_update_information) {`
`565`		`- if (g_find_program_in_path("git")) {`
	`565`	`+ char* gitPath = g_find_program_in_path("git");`
	`566`	`+`
	`567`	`+ if (gitPath != NULL) {`
`566`	`568`	`if (version_env == NULL) {`
`567`	`569`	`GError* error = NULL;`
`568`	`570`	`gchar* out = NULL;`
`@@ -602,6 +604,8 @@ main (int argc, char *argv[])`
`602`	`604`	`}`
`603`	`605`	`}`
`604`	`606`	`}`
	`607`	`+`
	`608`	`+ free(gitPath);`
`605`	`609`	`}`
`606`	`610`
`607`	`611`	`if(!((0 == strcmp(sqfs_comp, "gzip")) \|\| (0 ==strcmp(sqfs_comp, "xz"))))`