Skip to content

Commit 2c18914

Browse files
committed
define all dataProvider as static
1 parent fb2fe83 commit 2c18914

File tree

3 files changed

+14
-14
lines changed

3 files changed

+14
-14
lines changed

tests/Fixtures/HelperTrait.php

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ trait HelperTrait
3333
*
3434
* @see http://json.org/
3535
*/
36-
public function jsonValuesProvider()
36+
public static function jsonValuesProvider(): array
3737
{
3838
return [
3939
[new \stdClass()],
@@ -53,9 +53,9 @@ public function jsonValuesProvider()
5353
*
5454
* @see http://json.org/
5555
*/
56-
public function jsonValuesProviderWithoutObject()
56+
public static function jsonValuesProviderWithoutObject(): array
5757
{
58-
$data = $this->jsonValuesProvider();
58+
$data = static::jsonValuesProvider();
5959

6060
unset($data[0]);
6161

@@ -67,9 +67,9 @@ public function jsonValuesProviderWithoutObject()
6767
*
6868
* @see http://json.org/
6969
*/
70-
public function jsonValuesProviderWithoutArray()
70+
public static function jsonValuesProviderWithoutArray(): array
7171
{
72-
$data = $this->jsonValuesProvider();
72+
$data = static::jsonValuesProvider();
7373

7474
unset($data[1]);
7575

@@ -81,9 +81,9 @@ public function jsonValuesProviderWithoutArray()
8181
*
8282
* @see http://json.org/
8383
*/
84-
public function jsonValuesProviderWithoutString()
84+
public static function jsonValuesProviderWithoutString(): array
8585
{
86-
$data = $this->jsonValuesProvider();
86+
$data = static::jsonValuesProvider();
8787

8888
unset($data[2]);
8989

@@ -95,9 +95,9 @@ public function jsonValuesProviderWithoutString()
9595
*
9696
* @see http://json.org/
9797
*/
98-
public function jsonValuesProviderWithoutObjectAndString()
98+
public static function jsonValuesProviderWithoutObjectAndString(): array
9999
{
100-
$data = $this->jsonValuesProvider();
100+
$data = static::jsonValuesProvider();
101101

102102
unset($data[0]);
103103
unset($data[2]);
@@ -110,7 +110,7 @@ public function jsonValuesProviderWithoutObjectAndString()
110110
*
111111
* @see http://json.org/
112112
*/
113-
public function jsonValuesAsStringProvider()
113+
public static function jsonValuesAsStringProvider(): array
114114
{
115115
return [
116116
['{}'],
@@ -130,9 +130,9 @@ public function jsonValuesAsStringProvider()
130130
*
131131
* @see http://json.org/
132132
*/
133-
public function jsonValuesAsStringProviderWithoutObject()
133+
public static function jsonValuesAsStringProviderWithoutObject(): array
134134
{
135-
$data = $this->jsonValuesAsStringProvider();
135+
$data = static::jsonValuesAsStringProvider();
136136

137137
unset($data[0]);
138138

tests/Functional/ParsingTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ class ParsingTest extends \Art4\JsonApiClient\Tests\Fixtures\TestCase
3434
/**
3535
* Provide Parser
3636
*/
37-
public function createParserProvider()
37+
public static function createParserProvider(): array
3838
{
3939
$errorAbortManagerParser = function ($string) {
4040
$manager = new ErrorAbortManager(new Factory());

tests/Functional/SerializerTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ class SerializerTest extends TestCase
3434
/**
3535
* Provide JSON API data
3636
*/
37-
public function jsonapiDataProvider()
37+
public static function jsonapiDataProvider(): array
3838
{
3939
$path = str_replace('/', \DIRECTORY_SEPARATOR, __DIR__ . '/../files/');
4040
$files = [];

0 commit comments

Comments
 (0)