Skip to content

Commit ff3773c

Browse files
committed
Ignore false positives by phpstan
1 parent d3e2710 commit ff3773c

File tree

3 files changed

+26
-11
lines changed

3 files changed

+26
-11
lines changed

.phpstan.neon

Lines changed: 23 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,33 +14,53 @@ parameters:
1414
scanDirectories:
1515
- vendor
1616

17+
treatPhpDocTypesAsCertain: false
18+
1719
ignoreErrors:
1820
-
19-
message: "#^Property Art4\\\\JsonApiClient\\\\V1\\\\ResourceNull\\:\\:\\$data is never read, only written\\.$#"
21+
message: "#^Constructor of class Art4\\\\JsonApiClient\\\\V1\\\\ResourceNull has an unused parameter \\$data\\.$#"
2022
count: 1
2123
path: src/V1/ResourceNull.php
24+
# parameter is required by Art4\JsonApiClient\Element
2225

2326
-
24-
message: "#^Property Art4\\\\JsonApiClient\\\\V1\\\\ResourceNull\\:\\:\\$manager is never read, only written\\.$#"
27+
message: "#^Constructor of class Art4\\\\JsonApiClient\\\\V1\\\\ResourceNull has an unused parameter \\$manager\\.$#"
2528
count: 1
2629
path: src/V1/ResourceNull.php
30+
# parameter is required by Art4\JsonApiClient\Element
2731

2832
-
29-
message: "#^Property Art4\\\\JsonApiClient\\\\V1\\\\ResourceNull\\:\\:\\$parent is never read, only written\\.$#"
33+
message: "#^Constructor of class Art4\\\\JsonApiClient\\\\V1\\\\ResourceNull has an unused parameter \\$parent\\.$#"
3034
count: 1
3135
path: src/V1/ResourceNull.php
36+
# parameter is required by Art4\JsonApiClient\Element
3237

3338
-
3439
message: "#^Constructor of an anonymous class has an unused parameter \\$data\\.$#"
3540
count: 1
3641
path: tests/BC/ElementTest.php
42+
# parameter is required by Art4\JsonApiClient\Element
3743

3844
-
3945
message: "#^Constructor of an anonymous class has an unused parameter \\$manager\\.$#"
4046
count: 1
4147
path: tests/BC/ElementTest.php
48+
# parameter is required by Art4\JsonApiClient\Element
4249

4350
-
4451
message: "#^Constructor of an anonymous class has an unused parameter \\$parent\\.$#"
4552
count: 1
4653
path: tests/BC/ElementTest.php
54+
# parameter is required by Art4\JsonApiClient\Element
55+
56+
-
57+
message: "#^Parameter \\#1 \\$key of method Art4\\\\JsonApiClient\\\\V1\\\\ResourceNull\\:\\:has\\(\\) expects Art4\\\\JsonApiClient\\\\Helper\\\\AccessKey\\|int\\|string, array given\\.$#"
58+
count: 1
59+
path: tests/Unit/V1/ResourceNullTest.php
60+
# We are providing an invalid parameter to test the deprecation message
61+
62+
-
63+
message: "#^Parameter \\#1 \\$key of method Art4\\\\JsonApiClient\\\\V1\\\\ResourceNull\\:\\:has\\(\\) expects Art4\\\\JsonApiClient\\\\Helper\\\\AccessKey\\|int\\|string, stdClass given\\.$#"
64+
count: 1
65+
path: tests/Unit/V1/ResourceNullTest.php
66+
# We are providing an invalid parameter to test the deprecation message

src/V1/ResourceNull.php

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,6 @@
1919
*/
2020
final class ResourceNull implements Accessable, Element
2121
{
22-
/** @var mixed */
23-
private $data;
24-
private Manager $manager;
25-
private Accessable $parent;
26-
2722
/**
2823
* Constructor
2924
*
@@ -33,9 +28,6 @@ final class ResourceNull implements Accessable, Element
3328
*/
3429
public function __construct($data, Manager $manager, Accessable $parent)
3530
{
36-
$this->data = $data;
37-
$this->manager = $manager;
38-
$this->parent = $parent;
3931
}
4032

4133
/**

tests/Unit/Helper/AccessableTraitTest.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,14 @@
99
namespace Art4\JsonApiClient\Tests\Unit\Helper;
1010

1111
use Art4\JsonApiClient\Helper\AccessableTrait;
12+
use Art4\JsonApiClient\Accessable;
1213
use PHPUnit\Framework\TestCase;
1314

1415
class AccessableTraitTest extends TestCase
1516
{
1617
public function testHasWithObjectAsKeyTriggersException(): void
1718
{
19+
/** @var Accessable */
1820
$resource = $this->getMockForTrait(AccessableTrait::class);
1921

2022
// PHPUnit 10 compatible way to test trigger_error().
@@ -36,6 +38,7 @@ function ($errno, $errstr): bool {
3638

3739
public function testHasWithArrayAsKeyTriggersException(): void
3840
{
41+
/** @var Accessable */
3942
$resource = $this->getMockForTrait(AccessableTrait::class);
4043

4144
// PHPUnit 10 compatible way to test trigger_error().

0 commit comments

Comments
 (0)