handle integers as f64, error for non-numeric types

Author: mattjohnsonpint

std/assembly/util/number.ts

@@ -742,12 +742,19 @@ function dtoa_core(buffer: usize, value: f64, isSingle: bool): i32 {
 @lazy @inline const dtoa_buf = memory.data(MAX_DOUBLE_LENGTH << 1);
 
 export function dtoa<T extends number>(value: T): String {
-  // assert(isFloat<T>());
-  if (sizeof<T>() == 4) {
-    return dtoa_impl(<f32>value, true);
-  } else {
+  if (isInteger<T>()) {
     return dtoa_impl(<f64>value, false);
   }
+
+  if (isFloat<T>()) {
+    if (sizeof<T>() == 4) {
+      return dtoa_impl(<f32>value, true);
+    } else {
+      return dtoa_impl(<f64>value, false);
+    }
+  }
+  
+  ERROR("dtoa: unsupported type");
 }
 
 // @ts-ignore: decorator
@@ -843,12 +850,19 @@ export function itoa_buffered<T extends number>(buffer: usize, value: T): u32 {
 }
 
 export function dtoa_buffered<T extends number>(buffer: usize, value: T): u32 {
-  // assert(isFloat<T>());
-  if (sizeof<T>() == 4) {
-    return dtoa_buffered_impl(buffer, <f32>value, true);
-  } else {
+  if (isInteger<T>()) {
     return dtoa_buffered_impl(buffer, <f64>value, false);
   }
+
+  if (isFloat<T>()) {
+    if (sizeof<T>() == 4) {
+      return dtoa_buffered_impl(buffer, <f32>value, true);
+    } else {
+      return dtoa_buffered_impl(buffer, <f64>value, false);
+    }
+  }
+  
+  ERROR("dtoa_buffered: unsupported type");
 }
 
 // @ts-ignore: decorator

tests/compiler/issues/2873.debug.wat

@@ -3983,6 +3983,10 @@
   (local $value|3 f64)
   (local $isSingle i32)
   (local $sign i32)
+  i32.const 0
+  drop
+  i32.const 1
+  drop
   i32.const 4
   i32.const 4
   i32.eq
@@ -4082,6 +4086,10 @@
   (local $value|3 f64)
   (local $isSingle i32)
   (local $sign i32)
+  i32.const 0
+  drop
+  i32.const 1
+  drop
   i32.const 8
   i32.const 4
   i32.eq
@@ -5189,6 +5197,10 @@
   global.get $~lib/memory/__stack_pointer
   i32.const 0
   i32.store
+  i32.const 0
+  drop
+  i32.const 1
+  drop
   i32.const 4
   i32.const 4
   i32.eq
@@ -5270,6 +5282,10 @@
   global.get $~lib/memory/__stack_pointer
   i32.const 0
   i32.store
+  i32.const 0
+  drop
+  i32.const 1
+  drop
   i32.const 8
   i32.const 4
   i32.eq

tests/compiler/resolve-binary.debug.wat

@@ -7719,6 +7719,10 @@
   global.get $~lib/memory/__stack_pointer
   i32.const 0
   i32.store
+  i32.const 0
+  drop
+  i32.const 1
+  drop
   i32.const 8
   i32.const 4
   i32.eq

tests/compiler/resolve-elementaccess.debug.wat

@@ -5325,6 +5325,10 @@
   global.get $~lib/memory/__stack_pointer
   i32.const 0
   i32.store
+  i32.const 0
+  drop
+  i32.const 1
+  drop
   i32.const 4
   i32.const 4
   i32.eq

tests/compiler/resolve-ternary.debug.wat

@@ -4774,6 +4774,10 @@
   global.get $~lib/memory/__stack_pointer
   i32.const 0
   i32.store
+  i32.const 0
+  drop
+  i32.const 1
+  drop
   i32.const 8
   i32.const 4
   i32.eq

tests/compiler/std/array.debug.wat

@@ -8199,6 +8199,10 @@
   (local $value|3 f64)
   (local $isSingle i32)
   (local $sign i32)
+  i32.const 0
+  drop
+  i32.const 1
+  drop
   i32.const 8
   i32.const 4
   i32.eq
@@ -46897,6 +46901,10 @@
   global.get $~lib/memory/__stack_pointer
   i32.const 0
   i32.store
+  i32.const 0
+  drop
+  i32.const 1
+  drop
   i32.const 8
   i32.const 4
   i32.eq