Skip to content
This repository was archived by the owner on Aug 7, 2023. It is now read-only.

Commit 9a4a01c

Browse files
authored
Update ESLint (#88)
* Update ESLint versions Updates to the following: * `eslint@^3.9.1` * `eslint-congfig-airbnb-base@^10.0.1` * `eslint-plugin-import@^2.2.0` * Fix lint issues and update config * Remove a redundant (and wrong) specification that this is `es6` environment. * Add missing trailing commas to function args
1 parent 539c63f commit 9a4a01c

File tree

3 files changed

+12
-11
lines changed

3 files changed

+12
-11
lines changed

lib/main.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,17 +20,17 @@ export default {
2020
this.subscriptions.add(
2121
atom.config.observe('linter-shellcheck.shellcheckExecutablePath', (value) => {
2222
this.executablePath = value;
23-
})
23+
}),
2424
);
2525
this.subscriptions.add(
2626
atom.config.observe('linter-shellcheck.enableNotice', (value) => {
2727
this.enableNotice = value;
28-
})
28+
}),
2929
);
3030
this.subscriptions.add(
3131
atom.config.observe('linter-shellcheck.userParameters', (value) => {
3232
this.userParameters = value.trim().split(' ').filter(Boolean);
33-
})
33+
}),
3434
);
3535
},
3636

package.json

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,9 @@
88
"engines": {
99
"atom": ">=1.4.0 <2.0.0"
1010
},
11-
"activationHooks": ["language-shellscript:grammar-used"],
11+
"activationHooks": [
12+
"language-shellscript:grammar-used"
13+
],
1214
"scripts": {
1315
"test": "apm test",
1416
"lint": "eslint ."
@@ -37,9 +39,9 @@
3739
},
3840
"devDependencies": {
3941
"coffeelint": "^1.15.7",
40-
"eslint": "^3.6.0",
41-
"eslint-config-airbnb-base": "^8.0.0",
42-
"eslint-plugin-import": "^1.16.0"
42+
"eslint": "^3.9.1",
43+
"eslint-config-airbnb-base": "^10.0.1",
44+
"eslint-plugin-import": "^2.2.0"
4345
},
4446
"eslintConfig": {
4547
"extends": "airbnb-base",
@@ -55,7 +57,6 @@
5557
]
5658
},
5759
"env": {
58-
"es6": true,
5960
"browser": true,
6061
"node": true
6162
},

spec/linter-shellcheck-spec.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ describe('The ShellCheck provider for Linter', () => {
1818

1919
waitsForPromise(() =>
2020
atom.packages.activatePackage('language-shellscript').then(() =>
21-
atom.workspace.open(cleanPath))
21+
atom.workspace.open(cleanPath)),
2222
);
2323

2424
atom.packages.triggerDeferredActivationHooks();
@@ -29,7 +29,7 @@ describe('The ShellCheck provider for Linter', () => {
2929
waitsForPromise(() =>
3030
atom.workspace.open(cleanPath).then(editor => lint(editor)).then((messages) => {
3131
expect(messages.length).toBe(0);
32-
})
32+
}),
3333
);
3434
});
3535

@@ -44,7 +44,7 @@ describe('The ShellCheck provider for Linter', () => {
4444
expect(messages[0].html).toBe(expectedMsg);
4545
expect(messages[0].filePath).toBe(badPath);
4646
expect(messages[0].range).toEqual([[0, 0], [0, 4]]);
47-
})
47+
}),
4848
);
4949
});
5050
});

0 commit comments

Comments
 (0)