Merge pull request #103 from AtomLinter/greenkeeper/eslint-config-airbnb-base-12.0.0

Update eslint-config-airbnb-base to version 12.0.0 🚀

Author: Arcanemagus

lib/main.js

@@ -21,13 +21,9 @@ export default {
       atom.config.observe('linter-shellcheck.shellcheckExecutablePath', (value) => {
         this.executablePath = value;
       }),
-    );
-    this.subscriptions.add(
       atom.config.observe('linter-shellcheck.enableNotice', (value) => {
         this.enableNotice = value;
       }),
-    );
-    this.subscriptions.add(
       atom.config.observe('linter-shellcheck.userParameters', (value) => {
         this.userParameters = value.trim().split(' ').filter(Boolean);
       }),

package.json

@@ -38,8 +38,8 @@
     "atom-package-deps": "^4.3.1"
   },
   "devDependencies": {
-    "eslint": "^4.3.0",
-    "eslint-config-airbnb-base": "^11.3.1",
+    "eslint": "^4.6.0",
+    "eslint-config-airbnb-base": "^12.0.0",
     "eslint-plugin-import": "^2.7.0"
   },
   "eslintConfig": {

spec/.eslintrc.js

@@ -1,6 +1,14 @@
 module.exports = {
   env: {
+    atomtest: true,
     jasmine: true,
-    atomtest: true
+  },
+  rules: {
+    "import/no-extraneous-dependencies": [
+      "error",
+      {
+        "devDependencies": true
+      }
+    ]
   }
 };

spec/linter-shellcheck-spec.js

@@ -6,7 +6,7 @@ const cleanPath = path.join(__dirname, 'fixtures', 'clean.sh');
 const badPath = path.join(__dirname, 'fixtures', 'bad.sh');
 
 describe('The ShellCheck provider for Linter', () => {
-  const lint = require('../lib/main.js').provideLinter().lint;
+  const { lint } = require('../lib/main.js').provideLinter();
 
   beforeEach(() => {
     atom.workspace.destroyActivePaneItem();
@@ -18,8 +18,7 @@ describe('The ShellCheck provider for Linter', () => {
 
     waitsForPromise(() =>
       atom.packages.activatePackage('language-shellscript').then(() =>
-        atom.workspace.open(cleanPath)),
-    );
+        atom.workspace.open(cleanPath)));
 
     atom.packages.triggerDeferredActivationHooks();
     waitsForPromise(() => activationPromise);
@@ -29,8 +28,7 @@ describe('The ShellCheck provider for Linter', () => {
     waitsForPromise(() =>
       atom.workspace.open(cleanPath).then(editor => lint(editor)).then((messages) => {
         expect(messages.length).toBe(0);
-      }),
-    );
+      }));
   });
 
   it('handles messages from ShellCheck', () => {
@@ -44,7 +42,6 @@ describe('The ShellCheck provider for Linter', () => {
         expect(messages[0].html).toBe(expectedMsg);
         expect(messages[0].filePath).toBe(badPath);
         expect(messages[0].range).toEqual([[0, 0], [0, 4]]);
-      }),
-    );
+      }));
   });
 });