add AKS Swiftv2 Manifold E2E in ACN pipeline #4128
Conversation
sharifnasser
force-pushed
the
sharifna/pipeline/singularity
branch
from
ac53d7a to
4c05682
Compare
sharifnasser
force-pushed
the
sharifna/pipeline/singularity
branch
from
0280e70 to
a452830
Compare
sharifnasser
changed the title
sharifnasser
force-pushed
the
sharifna/pipeline/singularity
branch
from
64db33a to
ce3da3d
Compare
sharifnasser
force-pushed
the
sharifna/pipeline/singularity
branch
from
ce3da3d to
4b8616c
Compare
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
This PR integrates AKS Swiftv2 Manifold E2E tests into the ACN pipeline to validate newer CNS/CNI versions against BYON Accelnet and IB scenarios on both Windows and Linux before release. The tests are added to both the run-pipeline (for manual runs) and the main pipeline (scheduled runs only).
- Adds a new stage template that triggers external Manifold E2E tests via Azure DevOps build definition
- Integrates the tests into both run-pipeline and scheduled pipeline workflows
- Tests run only on scheduled builds in the main pipeline to avoid unnecessary execution on every commit
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| .pipelines/run-pipeline.yaml | Adds Swiftv2 Manifold E2E stage after manifest generation, includes typo in comment ("Singularity" instead of "Manifold") |
| .pipelines/pipeline.yaml | Conditionally includes Swiftv2 Manifold E2E tests for scheduled builds only, depends on publish stage, has same typo in comment |
| .pipelines/multitenancy/swiftv2-manifold-e2e.stages.yaml | New template that triggers external Manifold E2E build with CNS/CNI version parameters, uses hardcoded stage name instead of parameterized value |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| parameters: | ||
| name: "swiftv2_manifold_e2e" | ||
| dependsOn: publish | ||
|
|
There was a problem hiding this comment.
Trailing whitespace detected on this line. Please remove the trailing whitespace for consistency with the rest of the codebase.
| scaleup: 50 | ||
|
|
||
| - ${{ if eq(variables['Build.Reason'], 'Schedule') }}: | ||
| # AKS Swiftv2 Singularity E2E tests |
There was a problem hiding this comment.
The comment indentation appears incorrect within the conditional block. The comment should be indented at the same level as the template inclusion below it (line 493). Both should be indented relative to the ${{ if ... }} conditional on line 491.
| # AKS Swiftv2 Singularity E2E tests | |
| # AKS Swiftv2 Singularity E2E tests |
| scaleup: 50 | ||
|
|
||
|
|
||
| # AKS Swiftv2 Singularity E2E tests |
There was a problem hiding this comment.
The comment mentions "Singularity" but the tests are actually "Manifold" E2E tests. Please update the comment to "# AKS Swiftv2 Manifold E2E tests" to match the actual functionality.
| # AKS Swiftv2 Singularity E2E tests | |
| # AKS Swiftv2 Manifold E2E tests |
There was a problem hiding this comment.
+1 let's have uniformity in naming
| scaleup: 50 | ||
|
|
||
| - ${{ if eq(variables['Build.Reason'], 'Schedule') }}: | ||
| # AKS Swiftv2 Singularity E2E tests |
There was a problem hiding this comment.
The comment mentions "Singularity" but the tests are actually "Manifold" E2E tests. Please update the comment to "# AKS Swiftv2 Manifold E2E tests" to match the actual functionality.
| # AKS Swiftv2 Singularity E2E tests | |
| # AKS Swiftv2 Manifold E2E tests |
| dependsOn: "" | ||
|
|
||
| stages: | ||
| - stage: manifolde2e |
There was a problem hiding this comment.
Stage name inconsistency: the stage is named "manifolde2e" (line 6) but it's missing an underscore. Consider changing to "manifold_e2e" to match the naming convention used for other E2E stages (e.g., "linux_azure_overlay_e2e", "aks_swift_e2e", etc.).
| - stage: manifolde2e | |
| - stage: manifold_e2e |
| authenticationMethod: 'OAuth Token' | ||
|
No newline at end of file |
There was a problem hiding this comment.
Trailing whitespace detected on this line. Please remove the trailing whitespace for consistency with the rest of the codebase.
| authenticationMethod: 'OAuth Token' | |
| authenticationMethod: 'OAuth Token' |
| scaleup: 50 | ||
|
|
||
|
|
||
| # AKS Swiftv2 Singularity E2E tests |
There was a problem hiding this comment.
+1 let's have uniformity in naming
| steps: | ||
| - task: TriggerBuild@3 | ||
| inputs: | ||
| buildDefinition: '391699' |
There was a problem hiding this comment.
if possible, add a comment somewhere in file on the URL of our runner that this will trigger, if not add in PR summary description
There was a problem hiding this comment.
The runner is implied in the buildDefinition value, as the URL would be:
https://msazure.visualstudio.com/One/_build?**definitionId=391699**
There was a problem hiding this comment.
I'd just add it in description if not already
| dependsOn: ["test"] | ||
| scaleup: 50 | ||
|
|
||
| - ${{ if eq(variables['Build.Reason'], 'Schedule') }}: |
There was a problem hiding this comment.
why do we need this condition?
There was a problem hiding this comment.
This is the ACN PR pipeline. We don't have enough infra (SKU quota, TiP sessions) for that many parallel runs (for every PR) on the Singularity Runners. Instead, this stage will only be included in Nightly Run schedule (once a day).
Reason for Change:
This PR adds AKS Swiftv2 Manifold E2E tests to the ACN pipeline to ensure that newer CNS/CNI versions pass these scenarios testing (BYON Accelnet and IB on Windows and Linux) before being released.
Issue Fixed:
Requirements:
Notes:
Testing: https://dev.azure.com/msazure/One/_build/results?buildId=145754085