Refactor integration tests (#813)

lucyzhang929 · web-flow · commit 0a183face185 · 2023-04-24T11:43:27.000-07:00
* create database once

* fix compat level test

* fix compat + logs

* start func host in the beginning

* fix change tracking

* fix tests

* fix tests

* add CSharpscript and fix change tracking

* set port

* update xunit analyzers &amp; temp skip failling tests

* update port from fixture

* pass console writeline as logger

* enable identity tests

* fix case sensitive tests + temp disable identity

* fix indent

* AddProductWithIdentityColumnIncluded fix

* AddProductWithIdentityColumnIncluded

* cleanup

* remove extra fixture

* default port

* fix csx
diff --git a/samples/Database/StoredProcedures/SelectProductsCost.sql b/samples/Database/StoredProcedures/SelectProductsCost.sql
@@ -1,6 +1,6 @@
-﻿CREATE PROCEDURE [SelectProductsCost] 
+﻿CREATE PROCEDURE [SelectProductsCost]
 	@cost INT
-AS 
-	SELECT [ProductId], [Name], [Cost] 
+AS
+	SELECT [ProductId], [Name], [Cost]
 	FROM [dbo].[Products]
 	WHERE [Cost] = @cost;
diff --git a/samples/Database/Tables/Products.sql b/samples/Database/Tables/Products.sql
@@ -1,4 +1,6 @@
-﻿CREATE TABLE [Products] (
+﻿DROP TABLE IF EXISTS [Products];
+
+CREATE TABLE [Products] (
 	[ProductId] [int] NOT NULL PRIMARY KEY,
 	[Name] [nvarchar](100) NULL,
 	[Cost] [int] NULL
diff --git a/samples/Database/Tables/ProductsCostNotNull.sql b/samples/Database/Tables/ProductsCostNotNull.sql
@@ -1,4 +1,6 @@
-﻿CREATE TABLE [ProductsCostNotNull] (
+﻿DROP TABLE IF EXISTS [ProductsCostNotNull];
+
+CREATE TABLE [ProductsCostNotNull] (
 	[ProductId] [int] NOT NULL PRIMARY KEY,
 	[Name] [nvarchar](100) NULL,
 	[Cost] [int] NOT NULL
diff --git a/samples/Database/Tables/ProductsNameNotNull.sql b/samples/Database/Tables/ProductsNameNotNull.sql
@@ -1,4 +1,6 @@
-﻿CREATE TABLE [ProductsNameNotNull] (
+﻿DROP TABLE IF EXISTS [ProductsNameNotNull];
+
+CREATE TABLE [ProductsNameNotNull] (
 	[ProductId] [int] NOT NULL PRIMARY KEY,
 	[Name] [nvarchar](100) NOT NULL,
 	[Cost] [int] NULL
diff --git a/samples/Database/Tables/ProductsWithDefaultPK.sql b/samples/Database/Tables/ProductsWithDefaultPK.sql
@@ -1,4 +1,6 @@
-﻿CREATE TABLE [ProductsWithDefaultPK] (
+﻿DROP TABLE IF EXISTS [ProductsWithDefaultPK];
+
+CREATE TABLE [ProductsWithDefaultPK] (
 	[ProductGuid] [uniqueidentifier] PRIMARY KEY NOT NULL DEFAULT(newsequentialid()),
 	[Name] [nvarchar](100) NULL,
 	[Cost] [int] NULL
diff --git a/samples/Database/Tables/ProductsWithIdentity.sql b/samples/Database/Tables/ProductsWithIdentity.sql
@@ -1,4 +1,6 @@
-﻿CREATE TABLE [ProductsWithIdentity] (
+﻿DROP TABLE IF EXISTS [ProductsWithIdentity];
+
+CREATE TABLE [ProductsWithIdentity] (
 	[ProductId] [int] PRIMARY KEY NOT NULL IDENTITY(1,1),
 	[Name] [nvarchar](100) NULL,
 	[Cost] [int] NULL
diff --git a/samples/Database/Tables/ProductsWithMultiplePrimaryColumnsAndIdentity.sql b/samples/Database/Tables/ProductsWithMultiplePrimaryColumnsAndIdentity.sql
@@ -1,4 +1,6 @@
-﻿CREATE TABLE [ProductsWithMultiplePrimaryColumnsAndIdentity] (
+﻿DROP TABLE IF EXISTS [ProductsWithMultiplePrimaryColumnsAndIdentity];
+
+CREATE TABLE [ProductsWithMultiplePrimaryColumnsAndIdentity] (
 	[ProductId] [int] NOT NULL IDENTITY(1,1),
 	[ExternalId] [int] NOT NULL,
 	[Name] [nvarchar](100) NULL,
diff --git a/samples/Database/Views/ProductsNamesView.sql b/samples/Database/Views/ProductsNamesView.sql
@@ -1,3 +1,3 @@
 ﻿CREATE VIEW ProductNames
-AS 
-	SELECT p.Name FROM Products p;
+AS
+    SELECT p.Name FROM Products p;
diff --git a/samples/samples-csharp/Database/StoredProcedures/Drop/DropSelectProductsCost.sql b/samples/samples-csharp/Database/StoredProcedures/Drop/DropSelectProductsCost.sql
@@ -0,0 +1 @@
+﻿DROP PROCEDURE IF EXISTS [SelectProductsCost];
diff --git a/samples/samples-csharp/Database/Views/Drop/DropProductsNamesView.sql b/samples/samples-csharp/Database/Views/Drop/DropProductsNamesView.sql
@@ -0,0 +1 @@
+﻿DROP VIEW IF EXISTS ProductNames;
diff --git a/test/Common/TestUtils.cs b/test/Common/TestUtils.cs
@@ -7,6 +7,7 @@
 using System.Diagnostics;
 using System.IO;
 using System.Reflection;
+using System.Runtime.InteropServices;
 using System.Text.RegularExpressions;
 using System.Threading;
 using System.Threading.Tasks;
@@ -257,5 +258,100 @@ public static string GetPathToBin()
         {
             return Path.GetDirectoryName(Assembly.GetAssembly(typeof(Product)).Location);
         }
+
+        public static string GetFunctionsCoreToolsPath()
+        {
+            // Determine npm install path from either env var set by pipeline or OS defaults
+            // Pipeline env var is needed as the Windows hosted agents installs to a non-traditional location
+            string nodeModulesPath = Environment.GetEnvironmentVariable("NODE_MODULES_PATH");
+            if (string.IsNullOrEmpty(nodeModulesPath))
+            {
+                nodeModulesPath = RuntimeInformation.IsOSPlatform(OSPlatform.Windows) ?
+                    Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.ApplicationData), @"npm\node_modules\") :
+                    @"/usr/local/lib/node_modules";
+            }
+
+            string funcExe = RuntimeInformation.IsOSPlatform(OSPlatform.Windows) ? "func.exe" : "func";
+            string funcPath = Path.Combine(nodeModulesPath, "azure-functions-core-tools", "bin", funcExe);
+
+            if (!File.Exists(funcPath))
+            {
+                if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
+                {
+                    // Search Program Files folder as well
+                    string programFilesFuncPath = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.ProgramFiles), "Microsoft", "Azure Functions Core Tools", funcExe);
+                    if (File.Exists(programFilesFuncPath))
+                    {
+                        return programFilesFuncPath;
+                    }
+                    throw new FileNotFoundException($"Azure Function Core Tools not found at {funcPath} or {programFilesFuncPath}");
+                }
+                else if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
+                {
+                    // Search Mac to see if brew installed location has azure function core tools
+                    string usrBinFuncPath = Path.Combine("/usr", "local", "bin", "func");
+                    if (File.Exists(usrBinFuncPath))
+                    {
+                        return usrBinFuncPath;
+                    }
+                    throw new FileNotFoundException($"Azure Function Core Tools not found at {funcPath} or {usrBinFuncPath}");
+                }
+                throw new FileNotFoundException($"Azure Function Core Tools not found at {funcPath}");
+            }
+
+            return funcPath;
+        }
+
+        // Set the default port to 7081 since the function hosts started in
+        // IntegrationTestFixture are already running on ports 7071 - 7080.
+        public const int DefaultPort = 7081;
+
+        public static int GetPort(SupportedLanguages lang, bool testFolder = false)
+        {
+            if (lang == SupportedLanguages.CSharp && !testFolder)
+            {
+                return 7071;
+            }
+            else if (lang == SupportedLanguages.CSharp && testFolder)
+            {
+                return 7072;
+            }
+            else if (lang == SupportedLanguages.Csx)
+            {
+                return 7073;
+            }
+            else if (lang == SupportedLanguages.JavaScript)
+            {
+                return 7074;
+            }
+            else if (lang == SupportedLanguages.PowerShell)
+            {
+                return 7075;
+            }
+            else if (lang == SupportedLanguages.Java && !testFolder)
+            {
+                return 7076;
+            }
+            else if (lang == SupportedLanguages.Java && testFolder)
+            {
+                return 7077;
+            }
+            else if (lang == SupportedLanguages.OutOfProc && !testFolder)
+            {
+                return 7078;
+            }
+            else if (lang == SupportedLanguages.OutOfProc && testFolder)
+            {
+                return 7079;
+            }
+            else if (lang == SupportedLanguages.Python)
+            {
+                return 7080;
+            }
+            else
+            {
+                throw new Exception($"Failed to get port for language: {lang}");
+            }
+        }
     }
 }
diff --git a/test/Database/Tables/ProductsColumnTypes.sql b/test/Database/Tables/ProductsColumnTypes.sql
@@ -1,4 +1,6 @@
-﻿CREATE TABLE [ProductsColumnTypes] (
+﻿DROP TABLE IF EXISTS [ProductsColumnTypes];
+
+CREATE TABLE [ProductsColumnTypes] (
     [ProductId] [int] NOT NULL PRIMARY KEY,
     [BigInt] [bigint],
     [Bit] [bit],
diff --git a/test/Database/Tables/ProductsUnsupportedTypes.sql b/test/Database/Tables/ProductsUnsupportedTypes.sql
@@ -1,3 +1,5 @@
+DROP TABLE IF EXISTS [ProductsUnsupportedTypes];
+
 CREATE TABLE [ProductsUnsupportedTypes] (
     [ProductId] [int] NOT NULL PRIMARY KEY,
     [TextCol] [text],
diff --git a/test/Database/Tables/ProductsWithReservedPrimaryKeyColumnNames.sql b/test/Database/Tables/ProductsWithReservedPrimaryKeyColumnNames.sql
@@ -1,4 +1,6 @@
-﻿CREATE TABLE [ProductsWithReservedPrimaryKeyColumnNames] (
+﻿DROP TABLE IF EXISTS [ProductsWithReservedPrimaryKeyColumnNames];
+
+CREATE TABLE [ProductsWithReservedPrimaryKeyColumnNames] (
 	[ProductId] [int] NOT NULL IDENTITY(1, 1),
 	[_az_func_ChangeVersion] [int] NOT NULL,
 	[_az_func_AttemptCount] [int] NOT NULL,
diff --git a/test/Database/Tables/ProductsWithUnsupportedColumnTypes.sql b/test/Database/Tables/ProductsWithUnsupportedColumnTypes.sql
@@ -1,3 +1,5 @@
+DROP TABLE IF EXISTS [ProductsWithUnsupportedColumnTypes];
+
 CREATE TABLE [ProductsWithUnsupportedColumnTypes] (
     [ProductId] [int] NOT NULL PRIMARY KEY,
     [Name] [nvarchar](100) NULL,
diff --git a/test/Database/Tables/ProductsWithoutPrimaryKey.sql b/test/Database/Tables/ProductsWithoutPrimaryKey.sql
@@ -1,4 +1,6 @@
-﻿CREATE TABLE [ProductsWithoutPrimaryKey] (
+﻿DROP TABLE IF EXISTS [ProductsWithoutPrimaryKey];
+
+CREATE TABLE [ProductsWithoutPrimaryKey] (
     [ProductId] [int] NOT NULL,
     [Name] [nvarchar](100) NULL,
     [Cost] [int] NULL
diff --git a/test/Integration/IntegrationTestBase.cs b/test/Integration/IntegrationTestBase.cs
diff --git a/test/Integration/IntegrationTestFixture.cs b/test/Integration/IntegrationTestFixture.cs
diff --git a/test/Integration/MultipleSqlBindingsIntegrationTests.cs b/test/Integration/MultipleSqlBindingsIntegrationTests.cs
diff --git a/test/Integration/SqlInputBindingIntegrationTests.cs b/test/Integration/SqlInputBindingIntegrationTests.cs
diff --git a/test/Integration/SqlOutputBindingIntegrationTests.cs b/test/Integration/SqlOutputBindingIntegrationTests.cs
diff --git a/test/Integration/SqlTriggerBindingIntegrationTestBase.cs b/test/Integration/SqlTriggerBindingIntegrationTestBase.cs
diff --git a/test/Integration/SqlTriggerBindingIntegrationTests.cs b/test/Integration/SqlTriggerBindingIntegrationTests.cs

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+DROP PROCEDURE IF EXISTS [SelectProductsCost];`