Remove java build step in integration test (#538)

* remove java build step + add to readme

* remove basetestfixture

* remove unused imports and add script

Author: lucyzhang929

performance/SqlBindingBenchmarks.cs

@@ -13,7 +13,7 @@ public static void Main(string[] args)
         {
             bool runAll = args.Length == 0;
 
-            using var testFixture = new BaseTestFixture(false);
+            using var testFixture = new IntegrationTestFixture();
 
             // **IMPORTANT** If changing these make sure to update template-steps-performance.yml as well
             if (runAll || args.Contains("input"))

scripts/BuildJavaProjectsAndRunIntegrationTests.ps1

@@ -0,0 +1,19 @@
+# Run this script from the root of the repository to build the
+# samples-java and test-java Azure Function projects and run the
+# Integration tests.
+
+# Maven is required to build the Java projects.
+# Instructions to download Maven can be found here:
+# https://github.com/Microsoft/vscode-azurefunctions/wiki/Configure-Maven
+
+# Build the samples-java project
+cd ./samples/samples-java
+mvn clean package
+
+# Build the test-java project
+cd ../../test/Integration/test-java
+mvn clean package
+
+# Run the Integration tests
+cd ../../..
+dotnet test

test/Integration/IntegrationTestFixture.cs

@@ -3,38 +3,23 @@
 
 using System;
 using System.Diagnostics;
-using System.IO;
-using Microsoft.Azure.WebJobs.Extensions.Sql.Tests.Common;
-using Xunit;
 
 namespace Microsoft.Azure.WebJobs.Extensions.Sql.Tests.Integration
 {
     /// <summary>
     /// Test fixture containing one-time setup code for Integration tests. See https://xunit.net/docs/shared-context for more details
     /// </summary>
-    public class IntegrationTestFixture : BaseTestFixture
-    {
-        public IntegrationTestFixture() : base(true) { }
-    }
-
-    /// <summary>
-    /// Base test fixture - xUnit doesn't allow parameterized constructors so the benchmark tests will use this directly.
-    /// </summary>
-    public class BaseTestFixture : IDisposable
+    public class IntegrationTestFixture : IDisposable
     {
         /// <summary>
         /// Host process for Azurite local storage emulator. This is required for non-HTTP trigger functions:
         /// https://docs.microsoft.com/azure/azure-functions/functions-develop-local
         /// </summary>
         private Process AzuriteHost;
 
-        public BaseTestFixture(bool buildJava)
+        public IntegrationTestFixture()
         {
             this.StartAzurite();
-            if (buildJava)
-            {
-                BuildJavaFunctionApps();
-            }
         }
 
         /// <summary>
@@ -56,44 +41,6 @@ protected void StartAzurite()
             this.AzuriteHost.Start();
         }
 
-        /// <summary>
-        /// Build the samples-java and test-java projects.
-        /// </summary>
-        private static void BuildJavaFunctionApps()
-        {
-            string samplesJavaPath = Path.Combine(TestUtils.GetPathToBin(), "SqlExtensionSamples", "Java");
-            BuildJavaFunctionApp(samplesJavaPath);
-
-            string testJavaPath = Path.Combine(TestUtils.GetPathToBin(), "..", "..", "..", "Integration", "test-java");
-            BuildJavaFunctionApp(testJavaPath);
-        }
-
-        /// <summary>
-        /// Run `mvn clean package` to build the Java function app.
-        /// </summary>
-        private static void BuildJavaFunctionApp(string workingDirectory)
-        {
-            var maven = new Process()
-            {
-                StartInfo = new ProcessStartInfo
-                {
-                    FileName = "mvn",
-                    Arguments = "clean package",
-                    WorkingDirectory = workingDirectory,
-                    WindowStyle = ProcessWindowStyle.Hidden,
-                    UseShellExecute = true
-                }
-            };
-
-            maven.Start();
-
-            const int buildJavaAppTimeoutInMs = 60000;
-            maven.WaitForExit(buildJavaAppTimeoutInMs);
-
-            bool isCompleted = maven.ExitCode == 0;
-            Assert.True(isCompleted, "Java function app did not build successfully");
-        }
-
         public void Dispose()
         {
             try

test/README.md

@@ -35,6 +35,9 @@ Our integration tests are based on functions from the samples project. To run in
 ### Extension Bundle
    If you've made any changes to the CSharp extension, you will need to run the CopySqlDllToExtensionBundle.Ps1 to update your local extension bundle so that the tests can run against your latest changes.
 
+### Running Java Tests
+   Run the BuildJavaProjectsAndRunIntegrationTests.ps1 script in the scripts folder from the root of the repo to build the java projects and run the integration tests.
+
  ## Adding New Integration Tests
    When adding a new integration test for a function follow these steps: