Fix CA1805 & CA1711 (#157)

Author: Charles-Gagnon

test/.editorconfig

@@ -1,9 +1,6 @@
 # See https://github.com/dotnet/roslyn-analyzers/blob/main/.editorconfig for an example on different settings and how they're used
 
 [*.cs]
-# Disable these until they can be fixed
-dotnet_diagnostic.CA1805.severity = silent
-dotnet_diagnostic.CA1711.severity = silent
 
 # Disabled
 dotnet_diagnostic.CA1309.severity = silent # Use ordinal StringComparison - this isn't important for tests and just adds clutter

test/Common/TestUtils.cs

@@ -13,7 +13,7 @@ namespace Microsoft.Azure.WebJobs.Extensions.Sql.Tests.Common
     /// </remarks>
     public static class TestUtils
     {
-        internal static int ThreadId = 0;
+        internal static int ThreadId;
 
         /// <summary>
         /// Returns a mangled name that unique based on Prefix + Machine + Process

test/GlobalSuppressions.cs

@@ -11,5 +11,5 @@
 // These suppression rules override parameters required by functions binding that cannot be converted to discard variables per issue: https://github.com/Azure/azure-functions-dotnet-worker/issues/323
 [assembly: SuppressMessage("Style", "IDE0060:Remove unused parameter", Justification = "Unused parameter is required by functions binding", Scope = "member", Target = "~M:Microsoft.Azure.WebJobs.Extensions.Sql.Tests.Integration.AddProductExtraColumns.Run(Microsoft.AspNetCore.Http.HttpRequest,Microsoft.Azure.WebJobs.Extensions.Sql.Tests.Common.ProductExtraColumns@)~Microsoft.AspNetCore.Mvc.IActionResult")]
 [assembly: SuppressMessage("Style", "IDE0060:Remove unused parameter", Justification = "Unused parameter is required by functions binding", Scope = "member", Target = "~M:Microsoft.Azure.WebJobs.Extensions.Sql.Tests.Integration.AddProductMissingColumns.Run(Microsoft.AspNetCore.Http.HttpRequest,Microsoft.Azure.WebJobs.Extensions.Sql.Tests.Common.ProductMissingColumns@)~Microsoft.AspNetCore.Mvc.IActionResult")]
-[assembly: SuppressMessage("Style", "IDE0060:Remove unused parameter", Justification = "Unused parameter is required by functions binding", Scope = "member", Target = "~M:Microsoft.Azure.WebJobs.Extensions.Sql.Tests.Integration.AddProductMissingColumnsException.Run(Microsoft.AspNetCore.Http.HttpRequest,Microsoft.Azure.WebJobs.Extensions.Sql.Tests.Common.ProductMissingColumns@)~Microsoft.AspNetCore.Mvc.IActionResult")]
+[assembly: SuppressMessage("Style", "IDE0060:Remove unused parameter", Justification = "Unused parameter is required by functions binding", Scope = "member", Target = "~M:Microsoft.Azure.WebJobs.Extensions.Sql.Tests.Integration.AddProductMissingColumnsExceptionFunction.Run(Microsoft.AspNetCore.Http.HttpRequest,Microsoft.Azure.WebJobs.Extensions.Sql.Tests.Common.ProductMissingColumns@)~Microsoft.AspNetCore.Mvc.IActionResult")]
 [assembly: SuppressMessage("Style", "IDE0060:Remove unused parameter", Justification = "Unused parameter is required by functions binding", Scope = "member", Target = "~M:Microsoft.Azure.WebJobs.Extensions.Sql.Tests.Integration.AddProductsNoPartialUpsert.Run(Microsoft.AspNetCore.Http.HttpRequest,Microsoft.Azure.WebJobs.ICollector{Microsoft.Azure.WebJobs.Extensions.Sql.Samples.Common.Product})~Microsoft.AspNetCore.Mvc.IActionResult")]

test/Integration/AddProductMissingColumnsException.cs

@@ -8,11 +8,11 @@
 
 namespace Microsoft.Azure.WebJobs.Extensions.Sql.Tests.Integration
 {
-    public static class AddProductMissingColumnsException
+    public static class AddProductMissingColumnsExceptionFunction
     {
-        // This output binding should throw an error since the ProductsCostNotNull table does not 
+        // This output binding should throw an error since the ProductsCostNotNull table does not
         // allows rows without a Cost value.
-        [FunctionName("AddProductMissingColumnsException")]
+        [FunctionName("AddProductMissingColumnsExceptionFunction")]
         public static IActionResult Run(
             [HttpTrigger(AuthorizationLevel.Anonymous, "get", Route = "addproduct-missingcolumnsexception")]
             HttpRequest req,

test/Integration/SqlOutputBindingIntegrationTests.cs

@@ -139,7 +139,7 @@ public void AddProductMissingColumnsTest()
         [Fact]
         public void AddProductMissingColumnsNotNullTest()
         {
-            this.StartFunctionHost(nameof(AddProductMissingColumnsException), true);
+            this.StartFunctionHost(nameof(AddProductMissingColumnsExceptionFunction), true);
 
             // Since the Sql table does not allow null for the Cost column,
             // inserting a row without a Cost value should throw an Exception.