Cleanup error events (#543)

Author: Charles-Gagnon

src/Telemetry/Telemetry.cs

@@ -423,7 +423,6 @@ public enum TelemetryErrorName
         GetScaleStatus,
         GetUnprocessedChangeCount,
         GetUnprocessedChangeCountRollback,
-        InvalidConfigurationValue,
         MissingPrimaryKeys,
         NoPrimaryKeys,
         ProcessChanges,
@@ -435,6 +434,7 @@ public enum TelemetryErrorName
         RenewLeasesLoop,
         RenewLeasesRollback,
         StartListener,
+        TriggerFunction,
         Upsert,
         UpsertRollback,
     }

src/TriggerBinding/SqlTableChangeMonitor.cs

@@ -444,7 +444,7 @@ private async Task ProcessTableChangesAsync(SqlConnection connection, Cancellati
                         // In the future might make sense to retry executing the function, but for now we just let
                         // another worker try.
                         this._logger.LogError($"Failed to trigger user function for table: '{this._userTable.FullName} due to exception: {result.Exception.GetType()}. Exception message: {result.Exception.Message}");
-                        TelemetryInstance.TrackException(TelemetryErrorName.ProcessChanges, result.Exception, this._telemetryProps, measures);
+                        TelemetryInstance.TrackException(TelemetryErrorName.TriggerFunction, result.Exception, this._telemetryProps, measures);
 
                         await this.ClearRowsAsync();
                     }