Skip to content

Commit f9bb835

Browse files
authored
Add comment for explaining token cancellation (#387)
1 parent 28080aa commit f9bb835

File tree

2 files changed

+1
-1
lines changed

2 files changed

+1
-1
lines changed

src/TriggerBinding/SqlTableChangeMonitor.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -156,6 +156,7 @@ public SqlTableChangeMonitor(
156156

157157
public void Dispose()
158158
{
159+
// When the CheckForChanges loop is finished, it will cancel the lease renewal loop.
159160
this._cancellationTokenSourceCheckForChanges.Cancel();
160161
}
161162

src/TriggerBinding/SqlTriggerListener.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,6 @@ public async Task StartAsync(CancellationToken cancellationToken)
115115

116116
this._logger.LogInformation($"Starting SQL trigger listener for table: '{this._userTable.FullName}', function ID: '{this._userFunctionId}'.");
117117

118-
// TODO: Check if passing the cancellation token would be beneficial.
119118
this._changeMonitor = new SqlTableChangeMonitor<T>(
120119
this._connectionString,
121120
userTableId,

0 commit comments

Comments
 (0)