Add pylint to ADO pipeline (#257)

* add pylint

* fix spacing

* add recursive

* fix lint errors

* escape parentheses and period

* match newline char on all platforms

Author: lucyzhang929

builds/azure-pipelines/template-steps-build-test.yml

@@ -65,6 +65,19 @@ steps:
   workingDirectory: $(Build.SourcesDirectory)/samples/samples-js
   displayName: Lint samples-js
 
+- task: UsePythonVersion@0
+  inputs:
+    versionSpec: '3.9' 
+    addToPath: true 
+    architecture: 'x64'
+
+- script: |
+    pip3 install pylint
+    pip3 install pylintfileheader
+    pylint --recursive=y .
+  workingDirectory: $(Build.SourcesDirectory)/samples/samples-python
+  displayName: Lint samples-python
+
 - task: securedevelopmentteam.vss-secure-development-tools.build-task-binskim.BinSkim@4
   inputs:
     InputType: 'CommandLine'

samples/samples-python/.pylintrc

@@ -0,0 +1,16 @@
+[MASTER]
+
+ignore=.venv
+
+# List of plugins (as comma separated values of python module names) to load,
+# usually to register additional checkers.
+load-plugins=pylintfileheader
+
+file-header=# Copyright \(c\) Microsoft Corporation\. All rights reserved\.[\r\n]+# Licensed under the MIT License\.
+
+[MESSAGES CONTROL]
+# Disable the message, report, category or checker with the given id(s). You
+# can either give multiple identifier separated by comma (,) or put this option
+# multiple time (only on the command line, not in the configuration file where
+# it should appear only once).
+disable= R0801, W0108, W0613, C0103, C0114, C0115, C0116, E0401

samples/samples-python/AddProduct/__init__.py

@@ -1,12 +1,13 @@
 # Copyright (c) Microsoft Corporation. All rights reserved.
 # Licensed under the MIT License.
 
-import azure.functions as func
 import json
+import azure.functions as func
 
 def main(req: func.HttpRequest, product: func.Out[func.SqlRow]) -> func.HttpResponse:
-    """Upsert the product, which will insert it into the Products table if the primary key (ProductId) for that item doesn't exist.
-    If it does then update it to have the new name and cost.
+    """Upsert the product, which will insert it into the Products table if the primary key
+    (ProductId) for that item doesn't exist. If it does then update it to have the new name
+    and cost.
     """
 
     # Note that this expects the body to be a JSON object which
@@ -19,4 +20,5 @@ def main(req: func.HttpRequest, product: func.Out[func.SqlRow]) -> func.HttpResp
         body=req.get_body(),
         status_code=201,
         mimetype="application/json"
-    )
+    )
+    

samples/samples-python/AddProductParams/__init__.py

@@ -13,4 +13,3 @@ def main(req: func.HttpRequest, product: func.Out[func.SqlRow]) -> func.HttpResp
         status_code=201,
         mimetype="application/json"
     )
-

samples/samples-python/AddProductWithIdentityColumn/__init__.py

@@ -13,9 +13,9 @@ def main(req: func.HttpRequest, product: func.Out[func.SqlRow]) -> func.HttpResp
 
     row_obj = func.SqlRow(ProductWithoutId(req.params["name"],req.params["cost"]))
     product.set(row_obj)
-    
+
     return func.HttpResponse(
         body=row_obj.to_json(),
         status_code=201,
         mimetype="application/json"
-    )
+    )

samples/samples-python/AddProductWithIdentityColumnIncluded/__init__.py

@@ -19,4 +19,4 @@ def main(req: func.HttpRequest, product: func.Out[func.SqlRow]) -> func.HttpResp
         body=row_obj.to_json(),
         status_code=201,
         mimetype="application/json"
-    )
+    )

samples/samples-python/AddProductWithMultiplePrimaryColumnsAndIdentity/__init__.py

@@ -12,11 +12,13 @@ def main(req: func.HttpRequest, product: func.Out[func.SqlRow]) -> func.HttpResp
     All other primary key columns are required to be in the object.
     """
 
-    row_obj = func.SqlRow(MultiplePrimaryKeyProductWithoutId(req.params["externalId"], req.params["name"], req.params["cost"]))
+    row_obj = func.SqlRow(MultiplePrimaryKeyProductWithoutId(req.params["externalId"],
+        req.params["name"], req.params["cost"]))
     product.set(row_obj)
 
     return func.HttpResponse(
         body=row_obj.to_json(),
         status_code=201,
         mimetype="application/json"
-    )
+    )
+    

samples/samples-python/AddProductsArray/__init__.py

@@ -1,12 +1,13 @@
 # Copyright (c) Microsoft Corporation. All rights reserved.
 # Licensed under the MIT License.
 
-import azure.functions as func
 import json
+import azure.functions as func
 
 def main(req: func.HttpRequest, products: func.Out[func.SqlRowList]) -> func.HttpResponse:
-    """This function upserts the products, which will insert them into the Products table if the primary key (ProductId) for that item doesn't exist.
-    If it does then update it to have the new name and cost.
+    """This function upserts the products, which will insert them into the Products table if
+    the primary key (ProductId) for that item doesn't exist. If it does then update it to have
+    the new name and cost.
     """
 
     # Note that this expects the body to be an array of JSON objects which
@@ -19,4 +20,4 @@ def main(req: func.HttpRequest, products: func.Out[func.SqlRowList]) -> func.Htt
         body=req.get_body(),
         status_code=201,
         mimetype="application/json"
-    )
+    )

samples/samples-python/Common/multiplePrimaryKeyProductWithoutId.py

@@ -8,4 +8,5 @@ def __init__(self, externalId, name, cost):
         super().__init__()
         self['ExternalId'] = externalId
         self['Name'] = name
-        self['Cost'] = cost
+        self['Cost'] = cost
+        

samples/samples-python/Common/product.py

@@ -8,4 +8,5 @@ def __init__(self, productId, name, cost):
         super().__init__()
         self['ProductId'] = productId
         self['Name'] = name
-        self['Cost'] = cost
+        self['Cost'] = cost
+