Skip to content

Causes ESLint error in host project development build #54

@krukid

Description

@krukid

Steps to repro:

  1. Install addon for your project with ember install ember-cli-workbox.
  2. Ensure you have valid .eslintrc.js in project root.
  3. Either run ember s or ember build.

Environment

  • Docker image node:10-slim
  • ember-cli@3.10.1
  • ember-cli-eslint@5.1.0
  • ember-source@3.10.1
  • eslint@5.16.0
  • eslint-plugin-ember@6.5.1
  • broccoli-lint-eslint@5.0.0

Using Yarn workspaces: https://yarnpkg.com/en/docs/workspaces

Result:

Build Error (broccoli-persistent-filter:EslintValidationFilter) in app/instance-initializers/sw.js

No ESLint configuration found.

Workaround 1:

Disable hinting in your project's ember-cli-build.js:

app = new EmberApp(defaults, {
  hinting: false,
  ...
})

Workaround 2:

Add the following path to .eslintignore in project's root directory:

ember-cli-workbox/

PS

Production build works out of the box as it should.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions