Initial Remote Specification

Author: Behemyth

cppython/plugins/conan/plugin.py

@@ -202,6 +202,24 @@ def publish(self) -> None:
         # Initialize Conan API
         conan_api = ConanAPI()
 
+        # Get configured remotes from Conan API and filter by our configuration
+        # TODO: We want to replace the global conan remotes with the ones configured in CPPython.
+        all_remotes = conan_api.remotes.list()
+        if not self.data.local_only:
+            # Filter remotes to only include those specified in configuration
+            configured_remotes = [remote for remote in all_remotes if remote.name in self.data.remotes]
+
+            if not configured_remotes:
+                available_remotes = [remote.name for remote in all_remotes]
+                raise ProviderConfigurationError(
+                    'conan',
+                    f'No configured remotes found. Available remotes: {available_remotes}, '
+                    f'Configured remotes: {self.data.remotes}',
+                    'remotes',
+                )
+        else:
+            configured_remotes = []
+
         # Step 1: Export the recipe to the cache
         # This is equivalent to the export part of `conan create`
         ref, conanfile = conan_api.export.export(
@@ -211,7 +229,7 @@ def publish(self) -> None:
             user=None,
             channel=None,
             lockfile=None,
-            remotes=conan_api.remotes.list(),
+            remotes=all_remotes,  # Use all remotes for dependency resolution during export
         )
 
         # Step 2: Get default profiles
@@ -230,7 +248,7 @@ def publish(self) -> None:
             profile_host=profile_host,
             profile_build=profile_build,
             lockfile=None,
-            remotes=conan_api.remotes.list(),
+            remotes=all_remotes,  # Use all remotes for dependency resolution
             update=None,
             check_updates=False,
             is_build_require=False,
@@ -240,33 +258,29 @@ def publish(self) -> None:
         conan_api.graph.analyze_binaries(
             graph=deps_graph,
             build_mode=['*'],  # Build from source (equivalent to the create behavior)
-            remotes=conan_api.remotes.list(),
+            remotes=all_remotes,  # Use all remotes for dependency resolution
             update=None,
             lockfile=None,
         )
 
         # Step 5: Install all dependencies and build the package
-        conan_api.install.install_binaries(deps_graph=deps_graph, remotes=conan_api.remotes.list())
+        conan_api.install.install_binaries(deps_graph=deps_graph, remotes=all_remotes)
 
-        # If not local, upload the package
-        if not self.data.local:
+        # If not local only, upload the package
+        if not self.data.local_only:
             # Get all packages matching the created reference
             ref_pattern = ListPattern(f'{ref.name}/*', package_id='*', only_recipe=False)
             package_list = conan_api.list.select(ref_pattern)
 
             if package_list.recipes:
-                # Get the first configured remote or raise an error
-                remotes = conan_api.remotes.list()
-                if not remotes:
-                    raise ProviderConfigurationError('conan', 'No remotes configured for upload', 'remotes')
-
-                remote = remotes[0]  # Use first remote
+                # Use the first configured remote for upload
+                remote = configured_remotes[0]
 
-                # Upload the package
+                # Upload the package to configured remotes
                 conan_api.upload.upload_full(
                     package_list=package_list,
                     remote=remote,
-                    enabled_remotes=remotes,
+                    enabled_remotes=configured_remotes,  # Only upload to configured remotes
                     check_integrity=False,
                     force=False,
                     metadata=None,

cppython/plugins/conan/resolution.py

@@ -43,4 +43,4 @@ def resolve_conan_data(data: dict[str, Any], core_data: CorePluginData) -> Conan
     """
     parsed_data = ConanConfiguration(**data)
 
-    return ConanData(local=parsed_data.local)
+    return ConanData(remotes=parsed_data.remotes)

cppython/plugins/conan/schema.py

@@ -30,12 +30,18 @@ def requires(self) -> str:
 class ConanData(CPPythonModel):
     """Resolved conan data"""
 
-    local: bool
+    remotes: list[str]
+
+    @property
+    def local_only(self) -> bool:
+        """Check if publishing should be local-only."""
+        return len(self.remotes) == 0
 
 
 class ConanConfiguration(CPPythonModel):
     """Raw conan data"""
 
-    local: Annotated[bool, Field(description='Whether to publish packages locally without uploading to a remote')] = (
-        False
-    )
+    remotes: Annotated[
+        list[str],
+        Field(description='List of remotes to upload to. Empty list means the local conan cache will be used.'),
+    ] = ['conancenter']

tests/fixtures/conan.py

@@ -79,7 +79,7 @@ def fixture_conan_mock_api_publish(mocker: MockerFixture) -> Mock:
 
     # Mock remotes module
     mock_remote = mocker.Mock()
-    mock_remote.name = 'origin'
+    mock_remote.name = 'conancenter'
     mock_api.remotes.list = mocker.Mock(return_value=[mock_remote])
 
     # Mock upload module

tests/unit/plugins/conan/test_install.py

@@ -31,7 +31,7 @@ def fixture_plugin_data() -> dict[str, Any]:
             The constructed plugin data
         """
         return {
-            'local': True,
+            'remotes': [],
         }
 
     @staticmethod

tests/unit/plugins/conan/test_publish.py

@@ -26,7 +26,7 @@ def fixture_plugin_data() -> dict[str, Any]:
             The constructed plugin data
         """
         return {
-            'local': False,
+            'remotes': ['conancenter'],
         }
 
     @staticmethod
@@ -42,7 +42,7 @@ def fixture_plugin_type() -> type[ConanProvider]:
     def test_publish_local_only(
         self, plugin: ConanProvider, conan_mock_api_publish: Mock, conan_temp_conanfile: None, mocker: MockerFixture
     ) -> None:
-        """Test that publish with local=True only exports and builds locally
+        """Test that publish with remotes=[] only exports and builds locally
 
         Args:
             plugin: The plugin instance
@@ -51,7 +51,7 @@ def test_publish_local_only(
             mocker: Pytest mocker fixture
         """
         # Set plugin to local mode
-        plugin.data.local = True
+        plugin.data.remotes = []
 
         # Mock the necessary imports and API creation
         mocker.patch('cppython.plugins.conan.plugin.ConanAPI', return_value=conan_mock_api_publish)
@@ -87,7 +87,7 @@ def test_publish_local_only(
     def test_publish_with_upload(
         self, plugin: ConanProvider, conan_mock_api_publish: Mock, conan_temp_conanfile: None, mocker: MockerFixture
     ) -> None:
-        """Test that publish with local=False exports, builds, and uploads
+        """Test that publish with remotes=['conancenter'] exports, builds, and uploads
 
         Args:
             plugin: The plugin instance
@@ -96,7 +96,7 @@ def test_publish_with_upload(
             mocker: Pytest mocker fixture
         """
         # Set plugin to upload mode
-        plugin.data.local = False
+        plugin.data.remotes = ['conancenter']
 
         # Mock the necessary imports and API creation
         mocker.patch('cppython.plugins.conan.plugin.ConanAPI', return_value=conan_mock_api_publish)
@@ -130,7 +130,7 @@ def test_publish_no_remotes_configured(
             mocker: Pytest mocker fixture
         """
         # Set plugin to upload mode
-        plugin.data.local = False
+        plugin.data.remotes = ['conancenter']
 
         # Mock the necessary imports and API creation
         mocker.patch('cppython.plugins.conan.plugin.ConanAPI', return_value=conan_mock_api_publish)
@@ -143,7 +143,7 @@ def test_publish_no_remotes_configured(
         conan_mock_api_publish.remotes.list.return_value = []
 
         # Execute publish and expect ProviderConfigurationError
-        with pytest.raises(ProviderConfigurationError, match='No remotes configured for upload'):
+        with pytest.raises(ProviderConfigurationError, match='No configured remotes found'):
             plugin.publish()
 
     def test_publish_no_packages_found(
@@ -158,7 +158,7 @@ def test_publish_no_packages_found(
             mocker: Pytest mocker fixture
         """
         # Set plugin to upload mode
-        plugin.data.local = False
+        plugin.data.remotes = ['conancenter']
 
         # Mock the necessary imports and API creation
         mocker.patch('cppython.plugins.conan.plugin.ConanAPI', return_value=conan_mock_api_publish)
@@ -188,7 +188,7 @@ def test_publish_uses_default_profiles(
             mocker: Pytest mocker fixture
         """
         # Set plugin to local mode
-        plugin.data.local = True
+        plugin.data.remotes = []
 
         # Mock the necessary imports and API creation
         mocker.patch('cppython.plugins.conan.plugin.ConanAPI', return_value=conan_mock_api_publish)
@@ -217,7 +217,7 @@ def test_publish_upload_parameters(
             mocker: Pytest mocker fixture
         """
         # Set plugin to upload mode
-        plugin.data.local = False
+        plugin.data.remotes = ['conancenter']
 
         # Mock the necessary imports and API creation
         mocker.patch('cppython.plugins.conan.plugin.ConanAPI', return_value=conan_mock_api_publish)
@@ -228,7 +228,7 @@ def test_publish_upload_parameters(
 
         # Mock remotes and package list
         mock_remote = MagicMock()
-        mock_remote.name = 'origin'
+        mock_remote.name = 'conancenter'
         remotes = [mock_remote]
         conan_mock_api_publish.remotes.list.return_value = remotes
 
@@ -262,7 +262,7 @@ def test_publish_list_pattern_creation(
             mocker: Pytest mocker fixture
         """
         # Set plugin to upload mode
-        plugin.data.local = False
+        plugin.data.remotes = ['conancenter']
 
         # Mock the necessary imports and API creation
         mocker.patch('cppython.plugins.conan.plugin.ConanAPI', return_value=conan_mock_api_publish)

tests/unit/plugins/conan/test_update.py

@@ -27,7 +27,7 @@ def fixture_plugin_data() -> dict[str, Any]:
             The constructed plugin data
         """
         return {
-            'local': True,
+            'remotes': [],
         }
 
     @staticmethod