Conan/Cmake: Handle Spaces in Binary Path

Author: Behemyth

cppython/plugins/conan/builder.py

@@ -1,7 +1,7 @@
 """Construction of Conan data"""
 
 import shutil
-from pathlib import Path
+from pathlib import Path, PurePosixPath
 
 from pydantic import DirectoryPath
 
@@ -48,11 +48,11 @@ def _create_base_conanfile(
 
         # Generate configure method content for cmake_program if specified
         if cmake_binary:
-            # Use forward slashes for cross-platform compatibility in Conan
-            cmake_path_str = str(cmake_binary.resolve()).replace('\\', '/')
+            # Use PurePosixPath for conan compatibility and space handling
+            cmake_path_str = f'"{PurePosixPath(cmake_binary.resolve())}"'
             configure_content = f'''    def configure(self):
         """CPPython managed configuration."""
-        self.conf.define("tools.cmake:cmake_program", "{cmake_path_str}")'''
+        self.conf.define("tools.cmake:cmake_program", {repr(cmake_path_str)})'''
         else:
             configure_content = ''
 

tests/unit/plugins/conan/test_builder.py

@@ -185,6 +185,17 @@ def test_cmake_binary_configure(self, builder: Builder, tmp_path: Path) -> None:
         assert 'C:/Program Files/CMake/bin/cmake.exe' in content
         assert '\\' not in content.split('tools.cmake:cmake_program')[1].split('"')[1]
 
+    def test_cmake_binary_path_with_spaces(self, builder: Builder, tmp_path: Path) -> None:
+        """Test that cmake_binary paths with spaces are quoted to prevent shell parsing errors."""
+        base_file = tmp_path / 'conanfile_base.py'
+        cmake_path = Path('C:/Program Files/CMake/bin/cmake.exe')
+
+        builder._create_base_conanfile(base_file, [], {}, cmake_binary=cmake_path)
+
+        content = base_file.read_text(encoding='utf-8')
+        # The path must be wrapped in quotes so Conan passes it as a single argument
+        assert '"C:/Program Files/CMake/bin/cmake.exe"' in content
+
     def test_no_cmake_binary(self, builder: Builder, tmp_path: Path) -> None:
         """Test that no cmake_binary means no configure() method."""
         base_file = tmp_path / 'conanfile_base.py'