From c66f3b2a3754db0543e996e533554772b6a8b50a Mon Sep 17 00:00:00 2001 From: Dan Brown Date: Thu, 7 Aug 2025 14:32:20 +0100 Subject: [PATCH 1/2] A11y: Improved tagging of profile menu - Swapped toggle out to actual button. - Ensured menu items have proper menu item role. - Added extra roles/labels where is makes sense. --- resources/sass/_header.scss | 1 + .../views/common/dark-mode-toggle.blade.php | 4 +-- .../layouts/parts/header-user-menu.blade.php | 32 ++++++++++++------- 3 files changed, 24 insertions(+), 13 deletions(-) diff --git a/resources/sass/_header.scss b/resources/sass/_header.scss index 3ec7275a480..a23f92d3faf 100644 --- a/resources/sass/_header.scss +++ b/resources/sass/_header.scss @@ -65,6 +65,7 @@ header { margin: 0 (-(vars.$s)); border-radius: 3px; gap: vars.$xs; + color: #FFF; > span { padding-inline-start: vars.$xs; display: inline-block; diff --git a/resources/views/common/dark-mode-toggle.blade.php b/resources/views/common/dark-mode-toggle.blade.php index 531755109ad..38493251902 100644 --- a/resources/views/common/dark-mode-toggle.blade.php +++ b/resources/views/common/dark-mode-toggle.blade.php @@ -3,8 +3,8 @@ {{ method_field('patch') }} @if(setting()->getForCurrentUser('dark-mode-enabled')) - + @else - + @endif \ No newline at end of file diff --git a/resources/views/layouts/parts/header-user-menu.blade.php b/resources/views/layouts/parts/header-user-menu.blade.php index db4820a4d8a..c252deb8218 100644 --- a/resources/views/layouts/parts/header-user-menu.blade.php +++ b/resources/views/layouts/parts/header-user-menu.blade.php @@ -1,33 +1,43 @@ - +
@@ -34,8 +34,8 @@ class="popup-background code-editor"> @foreach($languages as $language)
- - + +
@endforeach
diff --git a/resources/views/pages/parts/editor-toolbar.blade.php b/resources/views/pages/parts/editor-toolbar.blade.php index 2dfbe9e6982..ceb5dd64a7e 100644 --- a/resources/views/pages/parts/editor-toolbar.blade.php +++ b/resources/views/pages/parts/editor-toolbar.blade.php @@ -14,7 +14,7 @@ class="dropdown-container draft-display text {{ $draftsEnabled ? '' : 'hidden'