Skip to content

Commit ac46571

Browse files
fix a minor error with a default value in GeometrySchema
- remove references in init.py to clean a few references up - fix flake8 linting errors - there is a warning in geometry schema still, but should not cause an issue for the time being
1 parent 3ffd9ea commit ac46571

File tree

9 files changed

+12
-33
lines changed

9 files changed

+12
-33
lines changed

conSys4Py/__init__.py

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +0,0 @@
1-
from .constants import *
2-
from .datamodels.swe_components import *
3-
from .part_1 import capabilities as Capabilities
4-
from .part_1 import collections_ep as Collections
5-
from .part_1 import deployments as Deployments
6-
from .part_1 import procedures as Procedures
7-
from .part_1 import properties as Properties
8-
from .part_1 import sampling_features as SamplingFeatures
9-
from .part_1 import systems as Systems
10-
from .part_2 import commands as Commands
11-
from .part_2 import control_channels as ControlChannels
12-
from .part_2 import datastreams as Datastreams
13-
from .part_2 import observations as Observations
14-
from .part_2 import system_events as SystemEvents
15-
from .part_2 import system_history as SystemHistory
16-
from .querymodel import QueryModel
17-
from .request_bodies import *
18-
from .utilities import model_utils

conSys4Py/datamodels/control_streams.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@ class ControlStreamJSONSchema(BaseModel):
2121
valid_time: list = Field(None, serialization_alias='validTime')
2222
input_name: str = Field(None, serialization_alias='inputName')
2323
links: list = Field(None)
24-
control_stream_schema: SerializeAsAny[Union[SWEControlChannelSchema, JSONControlChannelSchema]] = Field(..., serialization_alias='schema')
24+
control_stream_schema: SerializeAsAny[Union[SWEControlChannelSchema, JSONControlChannelSchema]] = Field(...,
25+
serialization_alias='schema')
2526

2627

2728
class SWEControlChannelSchema(BaseModel):
@@ -35,4 +36,4 @@ class SWEControlChannelSchema(BaseModel):
3536

3637
class JSONControlChannelSchema(BaseModel):
3738
command_format: str = Field("application/cmd+json", serialization_alias='commandFormat')
38-
params_schema: SerializeAsAny[AnyComponentSchema] = Field(..., serialization_alias='paramsSchema')
39+
params_schema: SerializeAsAny[AnyComponentSchema] = Field(..., serialization_alias='paramsSchema')

conSys4Py/datamodels/geometry.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,4 @@ class Geometry(BaseModel):
1010
"""
1111
type: GeometryTypes = Field(...)
1212
coordinates: list
13-
bbox: list = None
13+
bbox: list = None

conSys4Py/datamodels/network_properties.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,4 @@ class NetworkProperties(BaseModel):
77
stream_protocol: str = 'ws'
88
mqtt_opts: dict = None
99
mqtt_endpoint_url: HttpUrl = None
10-
connector_opts: dict = None
10+
connector_opts: dict = None

conSys4Py/datamodels/observations.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
from datetime import datetime
2+
from typing import Union, List
23

34
from pydantic import BaseModel, Field
4-
from typing import Union, Optional, List
55

66
from conSys4Py.datamodels.api_utils import Link
77

@@ -17,4 +17,3 @@ class ObservationOMJSONInline(BaseModel):
1717
parameters: dict = Field(None)
1818
result: Union[int, float, str, dict, list] = Field(...)
1919
result_links: List[Link] = Field(None, serialization_alias="result@links")
20-

conSys4Py/datamodels/swe_components.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,14 @@
55

66
from pydantic import BaseModel, Field, field_validator, SerializeAsAny
77

8-
from conSys4Py import GeometryTypes
8+
from conSys4Py.constants import GeometryTypes
99
from conSys4Py.datamodels.api_utils import UCUMCode, URI
1010
from conSys4Py.datamodels.geometry import Geometry
1111

1212
"""
1313
NOTE: The following classes are used to represent the Record Schemas that are required for use with Datastreams
1414
The names are likely to change to include a "Schema" suffix to differentiate them from the actual data structures.
15-
The current scope of the project likely excludes conversion from received data to actual SWE Common data structures,
15+
The current scope of the project likely excludes conversion from received data to actual SWE Common data structures,
1616
in the event this is added it will most likely be in a separate module as those structures have use cases outside of
1717
the API solely
1818
"""
@@ -80,10 +80,10 @@ class GeometrySchema(AnyComponentSchema):
8080
updatable: bool = Field(False)
8181
optional: bool = Field(False)
8282
definition: str = Field(...)
83-
constraint: dict = {
84-
'geomTypes': [GeometryTypes.POINT.value, GeometryTypes.LINESTRING.value, GeometryTypes.POLYGON.value,
85-
GeometryTypes.MULTI_POINT.value, GeometryTypes.MULTI_LINESTRING.value,
86-
GeometryTypes.MULTI_POLYGON.value]}
83+
constraint: dict = Field(default_factory=dict(
84+
geomTypes=[GeometryTypes.POINT.value, GeometryTypes.LINESTRING.value, GeometryTypes.POLYGON.value,
85+
GeometryTypes.MULTI_POINT.value, GeometryTypes.MULTI_LINESTRING.value,
86+
GeometryTypes.MULTI_POLYGON.value]))
8787
nil_values: list = Field(None, serialization_alias='nilValues')
8888
srs: str = Field(...)
8989
value: Geometry = Field(None)

conSys4Py/part_2/control_channels.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
from typing import Union
22

3-
import requests
43
from pydantic import HttpUrl
54

65
from conSys4Py.con_sys_api import ConnectedSystemsRequestBuilder

conSys4Py/part_2/datastreams.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
from typing import Union
22

3-
import requests
43
from pydantic import HttpUrl
54

65
from conSys4Py.con_sys_api import ConnectedSystemsRequestBuilder

conSys4Py/part_2/observations.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
from typing import Union
22

3-
import requests
43
from pydantic import HttpUrl
54

65
from conSys4Py.con_sys_api import ConnectedSystemsRequestBuilder

0 commit comments

Comments
 (0)