Merge pull request #478 from Breeding-Insight/bug/BI-2269-2

BI-2269 - Two experiments with the same title loaded to rel-test: Concurency

Author: nickpalladino

src/main/java/org/breedinginsight/brapps/importer/services/processors/experiment/create/workflow/steps/CommitPendingImportObjectsStep.java

@@ -48,6 +48,7 @@
 import org.breedinginsight.services.OntologyService;
 import org.breedinginsight.services.ProgramLocationService;
 import org.breedinginsight.services.exceptions.DoesNotExistException;
+import org.breedinginsight.services.exceptions.UnprocessableEntityException;
 import org.breedinginsight.utilities.Utilities;
 
 import javax.inject.Inject;
@@ -58,6 +59,8 @@
 import java.util.Objects;
 import java.util.stream.Collectors;
 
+import static org.breedinginsight.brapps.importer.services.processors.experiment.ExperimentUtilities.PREEXISTING_EXPERIMENT_TITLE;
+
 @Singleton
 @Slf4j
 public class CommitPendingImportObjectsStep {
@@ -88,7 +91,7 @@ public CommitPendingImportObjectsStep(BrAPIListDAO brAPIListDAO,
     }
 
     // TODO: some common code between workflows here that could be broken out, removed append/update specific code
-    public void process(ProcessContext processContext, ProcessedData processedData) {
+    public void process(ProcessContext processContext, ProcessedData processedData) throws UnprocessableEntityException {
 
         PendingData pendingData = processContext.getPendingData();
         ImportContext importContext = processContext.getImportContext();
@@ -138,6 +141,24 @@ public void process(ProcessContext processContext, ProcessedData processedData)
 
         AuthenticatedUser actingUser = new AuthenticatedUser(upload.getUpdatedByUser().getName(), new ArrayList<>(), upload.getUpdatedByUser().getId(), new ArrayList<>());
 
+        // TODO: Implement more robust solution either brapi server side or possibly redis SETNX client side
+        // Do this check here, directly before creating new trials instead of in earlier step to minimize time window of race condition
+        if (!newTrials.isEmpty()) {
+            try {
+                List<BrAPITrial> cachedTrials = brapiTrialDAO.getTrials(program.getId());
+                List<String> existingTrialNames = cachedTrials.stream().map(BrAPITrial::getTrialName).collect(Collectors.toList());
+                List<String> newTrialNames = newTrials.stream().map(t -> Utilities.removeProgramKey(t.getTrialName(), program.getKey())).collect(Collectors.toList());
+                log.debug("** Trials Duplicate Check: {} -> {}", existingTrialNames, newTrialNames);
+                if (newTrialNames.stream().anyMatch(existingTrialNames::contains)) {
+                    log.debug("** New matches existing");
+                    throw new UnprocessableEntityException(PREEXISTING_EXPERIMENT_TITLE);
+                }
+            } catch (ApiException e) {
+                log.error("Error getting trials for duplicate name check", e);
+                throw new InternalServerException(e.getMessage(), e);
+            }
+        }
+
         try {
             List<BrAPIListSummary> createdDatasets = new ArrayList<>(brAPIListDAO.createBrAPILists(newDatasetRequests, program.getId(), upload));
             createdDatasets.forEach(summary -> obsVarDatasetByName.get(summary.getListName()).getBrAPIObject().setListDbId(summary.getListDbId()));