Skip to content
This repository was archived by the owner on Aug 1, 2025. It is now read-only.

Commit a8c891b

Browse files
committed
clear data list when updating ListEntity instead of setting null pointers on data items
1 parent 25a54cf commit a8c891b

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

src/main/java/org/brapi/test/BrAPITestServer/service/core/ListService.java

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -273,9 +273,12 @@ private void updateEntity(ListEntity entity, @Valid ListNewRequest list) throws
273273
item.setList(null);
274274
});
275275
}
276-
276+
277277
if (list.getData() != null) {
278-
List<ListItemEntity> items = new ArrayList<>();
278+
// Clear existing items
279+
entity.getData().clear();
280+
281+
// Add new items
279282
ListIterator<String> iter = list.getData().listIterator();
280283
while (iter.hasNext()) {
281284
String item = iter.next();
@@ -284,12 +287,12 @@ private void updateEntity(ListEntity entity, @Valid ListNewRequest list) throws
284287
itemEntity.setPosition(iter.nextIndex());
285288
itemEntity.setItem(item);
286289
itemEntity.setList(entity);
287-
items.add(itemEntity);
290+
entity.getData().add(itemEntity);
288291
}
289292
}
290-
entity.setData(items);
291293
} else {
292-
entity.setData(new ArrayList<>());
294+
entity.getData().clear();
293295
}
296+
294297
}
295298
}

0 commit comments

Comments
 (0)