Skip to content
This repository was archived by the owner on Aug 1, 2025. It is now read-only.

Commit b0a5d4b

Browse files
committed
Add general findByIdIn to BrAPIRepository to be used by importer
1 parent 83b2937 commit b0a5d4b

File tree

6 files changed

+10
-27
lines changed

6 files changed

+10
-27
lines changed

src/main/java/org/brapi/test/BrAPITestServer/repository/BrAPIRepository.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
import org.springframework.data.domain.Page;
1111
import org.springframework.data.domain.Pageable;
1212
import org.springframework.data.jpa.repository.JpaRepository;
13+
import org.springframework.data.jpa.repository.Query;
1314
import org.springframework.data.repository.NoRepositoryBean;
1415

1516
@NoRepositoryBean
@@ -30,4 +31,6 @@ public interface BrAPIRepository<T extends BrAPIPrimaryEntity, ID extends Serial
3031
public <S extends T> void refresh(S entity);
3132

3233
public void fetchXrefs(Page<T> page, Class<T> searchClass) throws InvalidPagingException;
34+
35+
List<T> findByIdIn(List<ID> ids);
3336
}

src/main/java/org/brapi/test/BrAPITestServer/repository/BrAPIRepositoryImpl.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,10 @@ public Optional<T> findById(ID id) {
119119
return response;
120120
}
121121

122+
public List<T> findByIdIn(List<ID> ids) {
123+
return super.findAllById(ids);
124+
}
125+
122126
public <S extends T> S save(S entity) {
123127
entity.setAuthUserId(SecurityUtils.getCurrentUserId());
124128
return super.save(entity);

src/main/java/org/brapi/test/BrAPITestServer/repository/germ/BreedingMethodRepository.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,5 @@
33
import org.brapi.test.BrAPITestServer.model.entity.germ.BreedingMethodEntity;
44
import org.brapi.test.BrAPITestServer.repository.BrAPIRepository;
55

6-
import java.util.List;
7-
import java.util.Set;
8-
9-
public interface BreedingMethodRepository extends BrAPIRepository<BreedingMethodEntity, String>{
10-
public List<BreedingMethodEntity> findByIdIn(List<String> id);
6+
public interface BreedingMethodRepository extends BrAPIRepository<BreedingMethodEntity, String> {
117
}

src/main/java/org/brapi/test/BrAPITestServer/repository/germ/CrossingProjectRepository.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,4 @@
44
import org.brapi.test.BrAPITestServer.repository.BrAPIRepository;
55

66
public interface CrossingProjectRepository extends BrAPIRepository<CrossingProjectEntity, String> {
7-
87
}

src/main/java/org/brapi/test/BrAPITestServer/repository/germ/GermplasmRepository.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,5 @@ public interface GermplasmRepository extends BrAPIRepository<GermplasmEntity, St
2020
@Query("UPDATE GermplasmEntity g SET g.softDeleted = :softDeleted WHERE g.id IN :germplasmIds")
2121
int updateSoftDeletedStatusBatch(@Param("germplasmIds") List<String> germplasmIds, @Param("softDeleted") boolean softDeleted);
2222

23-
List<GermplasmEntity> findByIdIn(List<String> ids);
24-
2523
List<GermplasmEntity> findByGermplasmNameIn(List<String> germplasmNames);
2624
}

src/main/java/org/brapi/test/BrAPITestServer/service/germ/CrossingProjectService.java

Lines changed: 2 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -70,25 +70,8 @@ public List<CrossingProject> findCrossingProjects(String crossingProjectDbId, St
7070
return crossingProjects;
7171
}
7272

73-
public List<CrossingProjectEntity> findCrossingProjectsByIds(List<String> crossingProjectIds)
74-
throws BrAPIServerException {
75-
Metadata metadata = new Metadata().pagination(new IndexPagination());
76-
Pageable pageReq = PagingUtility.getPageRequest(metadata);
77-
78-
SearchQueryBuilder<CrossingProjectEntity> searchQuery = new SearchQueryBuilder<CrossingProjectEntity>(
79-
CrossingProjectEntity.class);
80-
81-
if (crossingProjectIds != null && !crossingProjectIds.isEmpty()) {
82-
searchQuery = searchQuery.appendList(crossingProjectIds, "id");
83-
}
84-
85-
Page<CrossingProjectEntity> page = crossingProjectRepository.findAllBySearchAndPaginate(searchQuery, pageReq);
86-
87-
if (page.hasContent()) {
88-
return page.getContent();
89-
}
90-
91-
return null;
73+
public List<CrossingProjectEntity> findCrossingProjectsByIds(List<String> crossingProjectIds) {
74+
return crossingProjectRepository.findByIdIn(crossingProjectIds);
9275
}
9376

9477
public CrossingProject getCrossingProject(String crossingProjectDbId) throws BrAPIServerException {

0 commit comments

Comments
 (0)