Merge pull request #43 from Breeding-Insight/bug/BI-2432

BI-2432 BJTS List updating broken

Author: dmeidlin

src/main/java/org/brapi/test/BrAPITestServer/service/core/ListService.java

@@ -268,14 +268,15 @@ private void updateEntity(ListEntity entity, @Valid ListNewRequest list) throws
 			entity.setListOwnerPerson(person);
 		}
 
-		if (entity.getData() != null) {
-			entity.getData().stream().forEach((item) -> {
-				item.setList(null);
-			});
-		}
-
 		if (list.getData() != null) {
-			List<ListItemEntity> items = new ArrayList<>();
+			// Clear existing items
+			if (entity.getData() == null) {
+				entity.setData(new ArrayList<>());
+			} else {
+				entity.getData().clear();
+			}
+
+			// Add new items
 			ListIterator<String> iter = list.getData().listIterator();
 			while (iter.hasNext()) {
 				String item = iter.next();
@@ -284,12 +285,16 @@ private void updateEntity(ListEntity entity, @Valid ListNewRequest list) throws
 					itemEntity.setPosition(iter.nextIndex());
 					itemEntity.setItem(item);
 					itemEntity.setList(entity);
-					items.add(itemEntity);
+					entity.getData().add(itemEntity);
 				}
 			}
-			entity.setData(items);
 		} else {
-			entity.setData(new ArrayList<>());
+			if (entity.getData() == null) {
+				entity.setData(new ArrayList<>());
+			} else {
+				entity.getData().clear();
+			}
 		}
+
 	}
 }