Add default sort to all SearchQueryBuilder queries on entity id.

If not specified, this sort will be used to keep the endpoints idempotent.

Author: jloux-brapi

src/main/java/io/swagger/model/SearchRequest.java

@@ -2,6 +2,8 @@
 
 import com.fasterxml.jackson.annotation.JsonIgnore;
 import com.fasterxml.jackson.annotation.JsonProperty;
+import io.swagger.model.core.SortBy;
+import io.swagger.model.core.SortOrder;
 
 import java.util.ArrayList;
 import java.util.List;

src/main/java/org/brapi/test/BrAPITestServer/service/SearchQueryBuilder.java

@@ -32,10 +32,22 @@ public SearchQueryBuilder(Class<T> clazz) {
 	}
 
 	public String getQuery() {
+		if (sortClause.isBlank()) {
+			// By default, sort on entity id to have query result remain idempotent
+			sortClause = " ORDER BY entity.id ASC ";
+		}
+
 		return selectClause + whereClause + sortClause;
 	}
 
-	public String getIdQuery() { return selectOnlyIds + whereClause + sortClause;}
+	public String getIdQuery() {
+		if (sortClause.isBlank()) {
+			// By default, sort on entity id to have query result remain idempotent
+			sortClause = " ORDER BY entity.id ASC ";
+		}
+
+		return selectOnlyIds + whereClause + sortClause;
+	}
 
 	public Map<String, Object> getParams() {
 		return params;

src/main/java/org/brapi/test/BrAPITestServer/service/germ/GermplasmService.java

@@ -4,6 +4,7 @@
 import java.util.*;
 import java.util.stream.Collectors;
 
+import io.swagger.model.core.SortOrder;
 import io.swagger.model.germ.*;
 import jakarta.validation.Valid;
 
@@ -137,7 +138,7 @@ public Page<GermplasmEntity> findGermplasmEntities(@Valid GermplasmSearchRequest
 					"*institute.instituteCode");
 		}
 
-				searchQuery.withExRefs(request.getExternalReferenceIDs(), request.getExternalReferenceSources())
+		searchQuery.withExRefs(request.getExternalReferenceIDs(), request.getExternalReferenceSources())
 				.appendList(request.getAccessionNumbers(), "accessionNumber")
 				.appendList(request.getCollections(), "collection")
 				.appendList(request.getCommonCropNames(), "crop.cropName").appendList(request.getGermplasmDbIds(), "id")