Skip to content

Commit 545b619

Browse files
authored
Bug/bugs in dialog (#282)
* fixed bugs in dialog * fixed #281
1 parent ae6656b commit 545b619

File tree

3 files changed

+8
-9
lines changed

3 files changed

+8
-9
lines changed

frontend/src/components/HomeComponents/Tasks/TaskDialog.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,9 +91,10 @@ export const TaskDialog = ({
9191
data-testid={`task-row-${task.id}`}
9292
id={`task-row-${task.id}`}
9393
key={index}
94-
className={`border-b cursor-pointer ${
95-
selectedIndex === index ? 'bg-muted/50' : ''
94+
className={`border-b cursor-pointer hover:dark:bg-muted/50 hover:bg-black/15 ${
95+
selectedIndex === index ? 'dark:bg-muted/50 bg-black/15' : ''
9696
}`}
97+
data-selected={selectedIndex === index}
9798
onClick={() => {
9899
onSelectTask(task, index);
99100
}}

frontend/src/components/HomeComponents/Tasks/Tasks.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,7 @@ export const Tasks = (
151151
target instanceof HTMLTextAreaElement ||
152152
target instanceof HTMLSelectElement ||
153153
_isDialogOpen ||
154+
isAddTaskOpen ||
154155
target.isContentEditable
155156
) {
156157
return;

frontend/src/components/HomeComponents/Tasks/__tests__/TaskDialog.test.tsx

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -609,19 +609,16 @@ describe('TaskDialog Component', () => {
609609

610610
describe('Selected State', () => {
611611
test('should highlight selected task row', () => {
612-
const { container } = render(
613-
<TaskDialog {...defaultProps} selectedIndex={0} />
614-
);
612+
render(<TaskDialog {...defaultProps} selectedIndex={0} />);
615613

616-
const taskRow = container.querySelector('.bg-muted\\/50');
617-
expect(taskRow).toBeInTheDocument();
614+
const taskRow = screen.getByText(mockTask.description).closest('tr');
615+
expect(taskRow).toHaveAttribute('data-selected', 'true');
618616
});
619617

620618
test('should not highlight non-selected task row', () => {
621619
render(<TaskDialog {...defaultProps} selectedIndex={1} />);
622-
623620
const taskRow = screen.getByText(mockTask.description).closest('tr');
624-
expect(taskRow).not.toHaveClass('bg-muted/50');
621+
expect(taskRow).toHaveAttribute('data-selected', 'false');
625622
});
626623
});
627624

0 commit comments

Comments
 (0)