Skip to content

Commit 111595c

Browse files
authored
Merge pull request #129 from CCPBioSim/125-add-temperature-and-parallel-arguments-to-we
Add parallelism and temperature to water entropy method call.
2 parents a6a00bb + 3240a92 commit 111595c

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

CodeEntropy/entropy.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -477,8 +477,10 @@ def _calculate_water_entropy(self, universe, start, end, step):
477477
end (int): End frame.
478478
step (int): Step size.
479479
"""
480-
Sorient_dict, _, vibrations, _ = (
481-
GetSolvent.get_interfacial_water_orient_entropy(universe, start, end, step)
480+
Sorient_dict, _, vibrations, _, _ = (
481+
GetSolvent.get_interfacial_water_orient_entropy(
482+
universe, start, end, step, self._args.temperature, parallel=True
483+
)
482484
)
483485

484486
# Log per-residue entropy using helper functions

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ dependencies = [
3939
"PyYAML==6.0.2",
4040
"python-json-logger==3.3.0",
4141
"tabulate==0.9.0",
42-
"waterEntropy==1.1.0"
42+
"waterEntropy==1.2.0"
4343
]
4444

4545
[project.urls]

tests/test_CodeEntropy/test_entropy.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1073,6 +1073,7 @@ def test_calculate_water_entropy(self, mock_get_entropy):
10731073
None,
10741074
mock_vibrations,
10751075
None,
1076+
None,
10761077
)
10771078

10781079
mock_universe = MagicMock()
@@ -1102,6 +1103,7 @@ def test_calculate_water_entropy_minimal(self, mock_get_entropy):
11021103
rotational_S={("ACE_1", "WAT"): 2.0},
11031104
),
11041105
None,
1106+
None,
11051107
)
11061108

11071109
# Simulate residue-level results already collected

0 commit comments

Comments
 (0)