Skip to content

Commit 1fe2686

Browse files
committed
Update to ensure the correct molecule type is displayed within the output tables
1 parent db39cd5 commit 1fe2686

File tree

2 files changed

+27
-20
lines changed

2 files changed

+27
-20
lines changed

CodeEntropy/config/data_logger.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,15 +23,13 @@ def save_dataframes_as_json(self, molecule_df, residue_df, outfile):
2323
with open(outfile, "w") as out:
2424
json.dump(data, out, indent=4)
2525

26-
def add_results_data(self, molecule, level, S_molecule):
26+
def add_results_data(self, molecule, level, type, S_molecule):
2727
"""Add data for molecule-level entries"""
28-
self.molecule_data.append([molecule, level, "Total Entropy", f"{S_molecule}"])
28+
self.molecule_data.append([molecule, level, type, f"{S_molecule}"])
2929

30-
def add_residue_data(self, molecule, residue, S_trans_residue):
30+
def add_residue_data(self, molecule, residue, type, S_trans_residue):
3131
"""Add data for residue-level entries"""
32-
self.residue_data.append(
33-
[molecule, residue, "Transvibrational", f"{S_trans_residue}"]
34-
)
32+
self.residue_data.append([molecule, residue, type, f"{S_trans_residue}"])
3533

3634
def log_tables(self):
3735
"""Log both tables at once"""

CodeEntropy/main_mcc.py

Lines changed: 23 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,9 @@ def main():
228228
residue_results_df = pd.concat(
229229
[residue_results_df, new_row], ignore_index=True
230230
)
231-
data_logger.add_residue_data(molecule, residue, S_trans_residue)
231+
data_logger.add_residue_data(
232+
molecule, residue, "Transvibrational", S_trans_residue
233+
)
232234

233235
S_rot_residue = EF.vibrational_entropy(
234236
torque_matrix, "torque", args.temperature, highest_level
@@ -246,7 +248,9 @@ def main():
246248
residue_results_df = pd.concat(
247249
[residue_results_df, new_row], ignore_index=True
248250
)
249-
data_logger.add_residue_data(molecule, residue, S_rot_residue)
251+
data_logger.add_residue_data(
252+
molecule, residue, "Rovibrational", S_rot_residue
253+
)
250254

251255
# Conformational entropy based on atom dihedral angle distributions
252256
# Gives entropy of conformations within each residue
@@ -277,7 +281,9 @@ def main():
277281
residue_results_df = pd.concat(
278282
[residue_results_df, new_row], ignore_index=True
279283
)
280-
data_logger.add_residue_data(molecule, residue, S_conf_residue)
284+
data_logger.add_residue_data(
285+
molecule, residue, "Conformational", S_conf_residue
286+
)
281287

282288
# Print united atom level results summed over all residues
283289
logger.debug(f"S_trans_{level} = {S_trans}")
@@ -292,7 +298,9 @@ def main():
292298

293299
results_df = pd.concat([results_df, new_row], ignore_index=True)
294300

295-
data_logger.add_results_data(molecule, level, S_trans)
301+
data_logger.add_results_data(
302+
molecule, level, "Transvibrational", S_trans
303+
)
296304

297305
logger.debug(f"S_rot_{level} = {S_rot}")
298306
new_row = pd.DataFrame(
@@ -305,7 +313,7 @@ def main():
305313
)
306314
results_df = pd.concat([results_df, new_row], ignore_index=True)
307315

308-
data_logger.add_results_data(molecule, level, S_rot)
316+
data_logger.add_results_data(molecule, level, "Rovibrational", S_rot)
309317
logger.debug(f"S_conf_{level} = {S_conf}")
310318

311319
new_row = pd.DataFrame(
@@ -318,7 +326,7 @@ def main():
318326
)
319327
results_df = pd.concat([results_df, new_row], ignore_index=True)
320328

321-
data_logger.add_results_data(molecule, level, S_conf)
329+
data_logger.add_results_data(molecule, level, "Conformational", S_conf)
322330

323331
if level in ("polymer", "residue"):
324332
# Vibrational entropy at every level
@@ -372,8 +380,10 @@ def main():
372380
# Concatenate the new row to the DataFrame
373381
results_df = pd.concat([results_df, new_row_rot], ignore_index=True)
374382

375-
data_logger.add_results_data(molecule, level, S_trans)
376-
data_logger.add_results_data(molecule, level, S_rot)
383+
data_logger.add_results_data(
384+
molecule, level, "Transvibrational", S_trans
385+
)
386+
data_logger.add_results_data(molecule, level, "Rovibrational", S_rot)
377387

378388
# Note: conformational entropy is not calculated at the polymer level,
379389
# because there is at most one polymer bead per molecule so no dihedral
@@ -405,7 +415,7 @@ def main():
405415
}
406416
)
407417
results_df = pd.concat([results_df, new_row], ignore_index=True)
408-
data_logger.add_results_data(molecule, level, S_conf)
418+
data_logger.add_results_data(molecule, level, "Conformational", S_conf)
409419

410420
# Orientational entropy based on network of neighbouring molecules,
411421
# only calculated at the highest level (whole molecule)
@@ -440,15 +450,14 @@ def main():
440450
)
441451
results_df = pd.concat([results_df, new_row], ignore_index=True)
442452

443-
data_logger.add_results_data(molecule, level, S_molecule)
453+
data_logger.add_results_data(
454+
molecule, level, "Molecule Total Entropy", S_molecule
455+
)
444456
data_logger.save_dataframes_as_json(
445457
results_df, residue_results_df, args.outfile
446458
)
447459

448-
logger.info(f"Molecule: {molecule}")
449-
data_logger.log_tables()
450-
451-
logger.info("Combined Molecules:")
460+
logger.info("Molecules:")
452461
data_logger.log_tables()
453462

454463

0 commit comments

Comments
 (0)