Skip to content

Commit 495bfba

Browse files
committed
refactor create builder
1 parent 5cc0f1b commit 495bfba

File tree

3 files changed

+11
-9
lines changed

3 files changed

+11
-9
lines changed

packages/core/src/lib/data-query/executor.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import {
22
DataSource,
3+
IncomingHttpHeaders,
34
PrepareParameterFunc,
45
RequestParameter,
56
} from '@vulcan-sql/core/models';
@@ -12,7 +13,8 @@ export interface IExecutor {
1213
createBuilder(
1314
profileName: string,
1415
query: string,
15-
parameterizer: IParameterizer
16+
parameterizer: IParameterizer,
17+
headers?: IncomingHttpHeaders
1618
): Promise<IDataQueryBuilder>;
1719
prepare: PrepareParameterFunc;
1820
}
@@ -39,14 +41,15 @@ export class QueryExecutor implements IExecutor {
3941
public async createBuilder(
4042
profileName: string,
4143
query: string,
42-
parameterizer: IParameterizer
44+
parameterizer: IParameterizer,
45+
headers?: IncomingHttpHeaders
4346
) {
4447
return new DataQueryBuilder({
4548
statement: query,
4649
parameterizer,
4750
dataSource: this.dataSourceFactory(profileName)!,
4851
profileName,
49-
headers: {},
52+
headers: headers || {},
5053
});
5154
}
5255
}

packages/core/src/lib/template-engine/built-in-extensions/cache/cacheTagRunner.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,15 +50,14 @@ export class CacheTagRunner extends TagRunner {
5050
// Set the default vulcan created cache table schema, so we could query the cache table directly, not need user to type schema in the SQL.
5151
query = `set schema=${vulcanCacheSchemaName};`.concat('\n').concat(query);
5252
// Create the builder which access "vulcan.cache" data source for cache layer query
53+
const headers = metadata.getHeaders();
5354
const builder = await this.executor.createBuilder(
5455
cacheProfileName,
5556
query,
56-
parameterizer
57+
parameterizer,
58+
headers
5759
);
5860
context.setVariable(name, builder);
59-
// pass header to builder
60-
const headers = metadata.getHeaders();
61-
if (headers) builder.setHeaders(headers);
6261

6362
// Set parameter back for upstream usage
6463
context.setVariable(PARAMETERIZER_VAR_NAME, parentParameterizer);

packages/core/src/lib/template-engine/built-in-extensions/query-builder/reqTagRunner.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,9 @@ export class ReqTagRunner extends TagRunner {
5959
builder = await this.executor.createBuilder(
6060
profileName,
6161
query,
62-
parameterizer
62+
parameterizer,
63+
headers
6364
);
64-
if (headers) builder.setHeaders(headers);
6565
context.setVariable(name, builder);
6666
}
6767

0 commit comments

Comments
 (0)