Skip to content

Commit a928615

Browse files
committed
rename env name, update test case
1 parent 295b870 commit a928615

File tree

3 files changed

+13
-2
lines changed

3 files changed

+13
-2
lines changed

packages/extension-store-canner/README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,8 @@ export PROFILE_CANNER_DRIVER_PASSWORD=<password>
6363
export PROFILE_CANNER_DRIVER_HOST=<host>
6464
# Canner enterprise driver port, the default is 7432
6565
export PROFILE_CANNER_DRIVER_PORT=<port>
66+
# Canner enterprise root user id
67+
export PROFILE_CANNER_DRIVER_ROOT_USER_ID=<userId>
6668
```
6769

6870
### Connect Canner Enterprise used storage.

packages/extension-store-canner/src/lib/config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ export const getEnvConfig = (): CannerStoreConfig => {
7070
Number(process.env['PROFILE_CANNER_DRIVER_CONNECTION_POOL_MAX']) || 10,
7171
},
7272
properties: {
73-
rootUserId: process.env['PROFILE_ROOT_USER_ID'],
73+
rootUserId: process.env['PROFILE_CANNER_DRIVER_ROOT_USER_ID'],
7474
},
7575
storage: {
7676
provider: process.env['STORAGE_PROVIDER'],

packages/extension-store-canner/src/test/cannerProfileReader.spec.ts

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,7 @@ describe('Test CannerProfileReader', () => {
120120
user: 'canner',
121121
password: 'secret-password',
122122
port: 7432,
123+
max: 10,
123124
};
124125
const expected = [
125126
{
@@ -129,6 +130,9 @@ describe('Test CannerProfileReader', () => {
129130
...connectionInfo,
130131
database: fakeWorkspaces.ws1.sqlName,
131132
},
133+
properties: {
134+
rootUserId: 'fakeRootUserId',
135+
},
132136
allow: '*',
133137
},
134138
{
@@ -138,6 +142,9 @@ describe('Test CannerProfileReader', () => {
138142
...connectionInfo,
139143
database: fakeWorkspaces.ws2.sqlName,
140144
},
145+
properties: {
146+
rootUserId: 'fakeRootUserId',
147+
},
141148
allow: '*',
142149
},
143150
] as Profile<Record<string, any>>[];
@@ -165,7 +172,9 @@ describe('Test CannerProfileReader', () => {
165172

166173
sinon.default.stub(configModule, 'getEnvConfig').returns({
167174
storage: sinon.stubInterface<configModule.StorageServiceOptions>(),
168-
properties: {},
175+
properties: {
176+
rootUserId: 'fakeRootUserId',
177+
},
169178
profile: {
170179
...connectionInfo,
171180
},

0 commit comments

Comments
 (0)