Skip to content

Commit 34945ad

Browse files
committed
Fix missing tsconfig lib and other jsdoc error
1 parent 51fba44 commit 34945ad

File tree

4 files changed

+10
-8
lines changed

4 files changed

+10
-8
lines changed

Specs/TypeScript/tsconfig.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@
33
"noEmit": true,
44
"types": [],
55
"strict": true,
6-
"isolatedModules": true
6+
"isolatedModules": true,
7+
"lib": ["ES2020", "DOM"]
78
},
89
"include": [
910
"index.ts",

Tools/jsdoc/tsconfig.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
{
22
"compilerOptions": {
3-
"noEmit": true,
4-
"types": []
3+
"noEmit": true,
4+
"types": [],
5+
"lib": ["ES2020", "DOM"]
56
},
67
"files": [
78
"../../Source/Cesium.d.ts"

packages/engine/Source/Renderer/Context.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1580,7 +1580,7 @@ Context.prototype.getObjectByPickColor = function (pickColor) {
15801580

15811581
/**
15821582
*
1583-
* @param {Map} pickObjects
1583+
* @param {Map<number, object>} pickObjects
15841584
* @param {number} key
15851585
* @param {Color} color
15861586
*/

packages/engine/Source/Scene/Picking.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -790,11 +790,11 @@ function addDrillPickedResults(
790790

791791
/**
792792
* Drill pick by repeatedly calling a given `pickCallback`, each time stripping away the previously picked objects.
793-
* @param {number} [limit=Number.MAX_VALUE] If supplied, stop drilling after collecting this many picks
794793
* @param {function(number): object[]} pickCallback Pick callback to execute each iteration
794+
* @param {number} [limit=Number.MAX_VALUE] If supplied, stop drilling after collecting this many picks
795795
* @returns {object[]} List of picked results
796796
*/
797-
function drillPick(limit, pickCallback) {
797+
function drillPick(pickCallback, limit) {
798798
// PERFORMANCE_IDEA: This function calls each primitive's update for each pass. Instead
799799
// we could update the primitive once, and then just execute their commands for each pass,
800800
// and cull commands for picked primitives. e.g., base on the command's owner.
@@ -863,7 +863,7 @@ Picking.prototype.drillPick = function (
863863
exclude: false,
864864
}));
865865
};
866-
const objects = drillPick(limit, pickCallback);
866+
const objects = drillPick(pickCallback, limit);
867867
return objects.map((element) => element.object);
868868
};
869869

@@ -1120,7 +1120,7 @@ function drillPickFromRay(
11201120
);
11211121
return pickResult ? [pickResult] : undefined;
11221122
};
1123-
return drillPick(limit, pickCallback);
1123+
return drillPick(pickCallback, limit);
11241124
}
11251125

11261126
function pickFromRay(

0 commit comments

Comments
 (0)