refactor: break down large functions in prompts_commands.py

zhujian0805 · claude · zhujian0805 · commit 7e837d1aa7b6 · 2025-12-01T06:44:55.000Z
- Refactored show_prompt_status() function into 6 smaller helper functions - Refactored uninstall_prompt() function into 4 smaller helper functions - Added comprehensive unit tests for all refactored functions - Improved code maintainability and test coverage (71%) - All existing functionality preserved and verified 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
diff --git a/.gitignore b/.gitignore
@@ -18,3 +18,4 @@ dist
 .venv
 .claude/*
 codebuddy_usage.md
+.coverage
diff --git a/code_assistant_manager/cli/prompts_commands.py b/code_assistant_manager/cli/prompts_commands.py
@@ -841,6 +841,25 @@ def uninstall_prompt(
 
     target_levels = resolve_level_targets(level, VALID_LEVELS, default="user")
 
+    # Collect all target files to uninstall
+    all_targets = _collect_uninstall_targets(target_apps, target_levels, project_dir)
+
+    if not all_targets:
+        typer.echo(f"{Colors.YELLOW}No matching prompt files found{Colors.RESET}")
+        return
+
+    # Confirm uninstallation unless force is specified
+    if not force:
+        _confirm_uninstall(all_targets)
+
+    # Perform the actual uninstallation
+    _perform_uninstall(all_targets)
+
+
+def _collect_uninstall_targets(
+    target_apps: List[str], target_levels: List[str], project_dir: Optional[Path]
+):
+    """Collect all target files that need to be uninstalled."""
     targets = []
     copilot_targets = []
 
@@ -861,35 +880,42 @@ def uninstall_prompt(
                 continue
 
             if app == "codebuddy":
-                if lvl == "project":
-                    base_dir = lvl_project_dir or Path.cwd()
-                    codebuddy_path = base_dir / "CODEBUDDY.md"
-                    agents_path = base_dir / "AGENTS.md"
-                    # Prefer CODEBUDDY.md, but report AGENTS.md too
-                    target = codebuddy_path if codebuddy_path.exists() else agents_path
-                    if target.exists():
-                        targets.append(("codebuddy", lvl, target, lvl_project_dir))
-                elif lvl == "user":
-                    user_path = Path.home() / ".codebuddy" / "CODEBUDDY.md"
-                    if user_path.exists():
-                        targets.append(("codebuddy", lvl, user_path, None))
+                _collect_codebuddy_targets(app, lvl, lvl_project_dir, targets)
                 continue
 
             file_path = get_prompt_file_path(app, lvl, lvl_project_dir)
-            if not file_path:
-                continue
-            targets.append((app, lvl, file_path, lvl_project_dir))
-
-    all_targets = targets + copilot_targets
+            if file_path:
+                targets.append((app, lvl, file_path, lvl_project_dir))
 
-    if not all_targets:
-        typer.echo(f"{Colors.YELLOW}No matching prompt files found{Colors.RESET}")
-        return
+    return targets + copilot_targets
 
-    if not force:
-        summary = ", ".join(f"{app}:{lvl}" for app, lvl, *_ in all_targets)
-        typer.confirm(f"Uninstall prompt files for {summary}?", abort=True)
 
+def _collect_codebuddy_targets(
+    app: str, lvl: str, lvl_project_dir: Optional[Path], targets: List
+):
+    """Collect CodeBuddy target files for uninstallation."""
+    if lvl == "project":
+        base_dir = lvl_project_dir or Path.cwd()
+        codebuddy_path = base_dir / "CODEBUDDY.md"
+        agents_path = base_dir / "AGENTS.md"
+        # Prefer CODEBUDDY.md, but report AGENTS.md too
+        target = codebuddy_path if codebuddy_path.exists() else agents_path
+        if target.exists():
+            targets.append(("codebuddy", lvl, target, lvl_project_dir))
+    elif lvl == "user":
+        user_path = Path.home() / ".codebuddy" / "CODEBUDDY.md"
+        if user_path.exists():
+            targets.append(("codebuddy", lvl, user_path, None))
+
+
+def _confirm_uninstall(all_targets):
+    """Show confirmation dialog for uninstallation."""
+    summary = ", ".join(f"{app}:{lvl}" for app, lvl, *_ in all_targets)
+    typer.confirm(f"Uninstall prompt files for {summary}?", abort=True)
+
+
+def _perform_uninstall(all_targets):
+    """Perform the actual file uninstallation."""
     for app, lvl, file_path, _ in all_targets:
         if not file_path.exists():
             typer.echo(
@@ -955,7 +981,17 @@ def show_prompt_status(
     """Show prompt status for all apps."""
     manager = _get_prompt_manager()
 
-    # Show default prompt first
+    # Show default prompt section
+    _show_default_prompt_section(manager)
+
+    levels_to_show = resolve_level_targets(level, VALID_LEVELS, default="all")
+
+    for lvl in levels_to_show:
+        _show_level_section(manager, lvl, project_dir)
+
+
+def _show_default_prompt_section(manager: PromptManager):
+    """Show the default prompt status section."""
     default_prompt = manager.get_default()
     if default_prompt:
         typer.echo(f"\n{Colors.BOLD}Default Prompt:{Colors.RESET}")
@@ -966,122 +1002,135 @@ def show_prompt_status(
             f"\n{Colors.BOLD}Default Prompt:{Colors.RESET} {Colors.YELLOW}(none set){Colors.RESET}"
         )
 
-    levels_to_show = resolve_level_targets(level, VALID_LEVELS, default="all")
 
-    for lvl in levels_to_show:
-        typer.echo(
-            f"\n{Colors.BOLD}Prompt Status ({lvl.capitalize()} Level):{Colors.RESET}\n"
-        )
+def _show_level_section(manager: PromptManager, lvl: str, project_dir: Optional[Path]):
+    """Show prompt status for a specific level."""
+    typer.echo(
+        f"\n{Colors.BOLD}Prompt Status ({lvl.capitalize()} Level):{Colors.RESET}\n"
+    )
 
-        # Determine which apps to show for this level
-        apps_for_level = USER_LEVEL_APPS if lvl == "user" else VALID_APP_TYPES
+    # Determine which apps to show for this level
+    apps_for_level = USER_LEVEL_APPS if lvl == "user" else VALID_APP_TYPES
 
-        for app_type in apps_for_level:
-            # Handle Copilot specially
-            if app_type == "copilot":
-                _show_copilot_status(manager, project_dir)
-                continue
+    for app_type in apps_for_level:
+        _show_app_status(manager, app_type, lvl, project_dir)
 
-            if app_type == "codebuddy":
-                # Show CodeBuddy status for user or project level
-                if lvl == "user":
-                    file_path = Path.home() / ".codebuddy" / "CODEBUDDY.md"
-                    try:
-                        live_content = manager.get_live_content(
-                            "codebuddy", level="user", project_dir=None
-                        )
-                    except Exception:
-                        live_content = None
-                else:
-                    base_dir = project_dir or Path.cwd()
-                    codebuddy_file = base_dir / "CODEBUDDY.md"
-                    agents_file = base_dir / "AGENTS.md"
-                    file_path = (
-                        codebuddy_file if codebuddy_file.exists() else agents_file
-                    )
-                    try:
-                        live_content = manager.get_live_content(
-                            "codebuddy", level="project", project_dir=project_dir
-                        )
-                    except Exception:
-                        live_content = None
-
-                typer.echo(f"{Colors.BOLD}CodeBuddy:{Colors.RESET}")
-                typer.echo(f"  {Colors.CYAN}File:{Colors.RESET} {file_path}")
 
-                linked_prompt = None
-                if live_content:
-                    for prompt_id, prompt in manager.get_all().items():
-                        if prompt.content.strip() == live_content.strip():
-                            linked_prompt = prompt
-                            break
+def _show_app_status(
+    manager: PromptManager, app_type: str, lvl: str, project_dir: Optional[Path]
+):
+    """Show status for a specific app at a specific level."""
+    # Handle Copilot specially
+    if app_type == "copilot":
+        _show_copilot_status(manager, project_dir)
+        return
 
-                if linked_prompt:
-                    typer.echo(
-                        f"  {Colors.BLUE}Linked Prompt:{Colors.RESET} {linked_prompt.name} ({linked_prompt.id})"
-                    )
+    if app_type == "codebuddy":
+        _show_codebuddy_status(manager, lvl, project_dir)
+        return
 
-                if file_path.exists():
-                    content = file_path.read_text(encoding="utf-8")
-                    if content.strip():
-                        lines = content.strip().split("\n")
-                        preview = (
-                            lines[0][:50] + "..." if len(lines[0]) > 50 else lines[0]
-                        )
-                        typer.echo(f"  {Colors.GREEN}Content:{Colors.RESET} {preview}")
-                        typer.echo(f"  {Colors.CYAN}Lines:{Colors.RESET} {len(lines)}")
-                    else:
-                        typer.echo(f"  {Colors.YELLOW}Content:{Colors.RESET} (empty)")
-                else:
-                    typer.echo(
-                        f"  {Colors.YELLOW}Content:{Colors.RESET} (file not found)"
-                    )
+    # Handle regular apps
+    _show_regular_app_status(manager, app_type, lvl, project_dir)
 
-                typer.echo()
-                continue
 
-            file_path = get_prompt_file_path(
-                app_type, lvl, project_dir if lvl == "project" else None
+def _show_codebuddy_status(
+    manager: PromptManager, lvl: str, project_dir: Optional[Path]
+):
+    """Show CodeBuddy status for user or project level."""
+    if lvl == "user":
+        file_path = Path.home() / ".codebuddy" / "CODEBUDDY.md"
+        try:
+            live_content = manager.get_live_content(
+                "codebuddy", level="user", project_dir=None
             )
+        except Exception:
+            live_content = None
+    else:
+        base_dir = project_dir or Path.cwd()
+        codebuddy_file = base_dir / "CODEBUDDY.md"
+        agents_file = base_dir / "AGENTS.md"
+        file_path = codebuddy_file if codebuddy_file.exists() else agents_file
+        try:
+            live_content = manager.get_live_content(
+                "codebuddy", level="project", project_dir=project_dir
+            )
+        except Exception:
+            live_content = None
 
-            typer.echo(f"{Colors.BOLD}{app_type.capitalize()}:{Colors.RESET}")
-            typer.echo(f"  {Colors.CYAN}File:{Colors.RESET} {file_path}")
+    typer.echo(f"{Colors.BOLD}CodeBuddy:{Colors.RESET}")
+    typer.echo(f"  {Colors.CYAN}File:{Colors.RESET} {file_path}")
 
-            # Check which prompt is linked to this file
-            linked_prompt = None
-            try:
-                live_content = manager.get_live_content(
-                    app_type,
-                    level=lvl,
-                    project_dir=project_dir if lvl == "project" else None,
-                )
-                if live_content:
-                    # Find which stored prompt matches this content
-                    for prompt_id, prompt in manager.get_all().items():
-                        if prompt.content.strip() == live_content.strip():
-                            linked_prompt = prompt
-                            break
-            except Exception:
-                pass
+    linked_prompt = None
+    if live_content:
+        for prompt_id, prompt in manager.get_all().items():
+            if prompt.content.strip() == live_content.strip():
+                linked_prompt = prompt
+                break
 
-            if linked_prompt:
-                typer.echo(
-                    f"  {Colors.BLUE}Linked Prompt:{Colors.RESET} {linked_prompt.name} ({linked_prompt.id})"
-                )
+    if linked_prompt:
+        typer.echo(
+            f"  {Colors.BLUE}Linked Prompt:{Colors.RESET} {linked_prompt.name} ({linked_prompt.id})"
+        )
 
-            if file_path and file_path.exists():
-                content = file_path.read_text(encoding="utf-8")
-                if content.strip():
-                    lines = content.strip().split("\n")
-                    preview = lines[0][:50] + "..." if len(lines[0]) > 50 else lines[0]
-                    typer.echo(f"  {Colors.GREEN}Content:{Colors.RESET} {preview}")
-                    typer.echo(f"  {Colors.CYAN}Lines:{Colors.RESET} {len(lines)}")
-                else:
-                    typer.echo(f"  {Colors.YELLOW}Content:{Colors.RESET} (empty)")
-            else:
-                typer.echo(f"  {Colors.YELLOW}Content:{Colors.RESET} (file not found)")
+    if file_path.exists():
+        content = file_path.read_text(encoding="utf-8")
+        if content.strip():
+            lines = content.strip().split("\n")
+            preview = lines[0][:50] + "..." if len(lines[0]) > 50 else lines[0]
+            typer.echo(f"  {Colors.GREEN}Content:{Colors.RESET} {preview}")
+            typer.echo(f"  {Colors.CYAN}Lines:{Colors.RESET} {len(lines)}")
+        else:
+            typer.echo(f"  {Colors.YELLOW}Content:{Colors.RESET} (empty)")
+    else:
+        typer.echo(f"  {Colors.YELLOW}Content:{Colors.RESET} (file not found)")
 
-            typer.echo()
+    typer.echo()
+
+
+def _show_regular_app_status(
+    manager: PromptManager, app_type: str, lvl: str, project_dir: Optional[Path]
+):
+    """Show status for regular apps (non-copilot, non-codebuddy)."""
+    file_path = get_prompt_file_path(
+        app_type, lvl, project_dir if lvl == "project" else None
+    )
+
+    typer.echo(f"{Colors.BOLD}{app_type.capitalize()}:{Colors.RESET}")
+    typer.echo(f"  {Colors.CYAN}File:{Colors.RESET} {file_path}")
+
+    # Check which prompt is linked to this file
+    linked_prompt = None
+    try:
+        live_content = manager.get_live_content(
+            app_type,
+            level=lvl,
+            project_dir=project_dir if lvl == "project" else None,
+        )
+        if live_content:
+            # Find which stored prompt matches this content
+            for prompt_id, prompt in manager.get_all().items():
+                if prompt.content.strip() == live_content.strip():
+                    linked_prompt = prompt
+                    break
+    except Exception:
+        pass
+
+    if linked_prompt:
+        typer.echo(
+            f"  {Colors.BLUE}Linked Prompt:{Colors.RESET} {linked_prompt.name} ({linked_prompt.id})"
+        )
+
+    if file_path and file_path.exists():
+        content = file_path.read_text(encoding="utf-8")
+        if content.strip():
+            lines = content.strip().split("\n")
+            preview = lines[0][:50] + "..." if len(lines[0]) > 50 else lines[0]
+            typer.echo(f"  {Colors.GREEN}Content:{Colors.RESET} {preview}")
+            typer.echo(f"  {Colors.CYAN}Lines:{Colors.RESET} {len(lines)}")
+        else:
+            typer.echo(f"  {Colors.YELLOW}Content:{Colors.RESET} (empty)")
+    else:
+        typer.echo(f"  {Colors.YELLOW}Content:{Colors.RESET} (file not found)")
 
 
 def _show_copilot_status(manager: PromptManager, project_dir: Optional[Path]):
diff --git a/tests/unit/test_prompts_cli.py b/tests/unit/test_prompts_cli.py
