changed to more easy function with if statements

Author: Grajales-K

Sprint-3/implement/get-card-value.js

@@ -6,60 +6,111 @@
 
 // Acceptance criteria:
 
-// Given a card string in the format "A♠" (representing a card in blackjack - 
+// 1. Given a card string in the format "A♠" (representing a card in blackjack -
 // the last character will always be an emoji for a suit, and all characters
 // before will be a number 2-10, or one letter of J, Q, K, A),
 // When the function getCardValue is called with this card string as input,
 // Then it should return the numerical card value
 
-// Handle Number Cards (2-10):
+// 2. Handle Number Cards (2-10):
 // Given a card with a rank between "2" and "9",
 // When the function is called with such a card,
-// Then it should return the numeric value corresponding to the rank 
+// Then it should return the numeric value corresponding to the rank
 // (e.g., "5" should return 5).
 
-// Handle Face Cards (J, Q, K):
+// 3. Handle Face Cards (J, Q, K):
 // Given a card with a rank of "10," "J," "Q," or "K",
 // When the function is called with such a card,
 // Then it should return the value 10, as these cards are worth 10 points each
 //  in blackjack.
 
-// Handle Ace (A):
+// 4. Handle Ace (A):
 // Given a card with a rank of "A",
 // When the function is called with an Ace,
 // Then it should, by default, assume the Ace is worth 11 points, which is a common rule in blackjack.
 
-// Handle Invalid Cards:
+// 5. Handle Invalid Cards:
 // Given a card with an invalid rank (neither a number nor a recognized face card),
 // When the function is called with such a card,
 // Then it should throw an error indicating "Invalid card rank."
 
+// ========================= getCardValue ===========================
 
-function IdentifyNumberCard (input){
-  //we validate and convert into str and upperCase before to compare with our local var
-  const chain = input.toString().toUpperCase();
+function getCardValue (input){
+  const rank = input.slice(0, -1);
 
-  //Option that we want to check
-  const faceCards = ["K", "J", "Q", "10"];
-  const ace = "A";
-  const numberCards = [1, 2, 3, 4, 5, 6, 7, 8, 9];
-  const suits = ["♠", "♥", "♣", "♦"];
+  // console.log(rank)
+  // return rank//fist character
 
-  if (faceCards.includes(chain)) {
+  if (input === "10") 
     return 10;
+
+  else if (rank > 1 && rank < 11) {
+    return Number(rank);
   }
-  //!isNaN(chain) ensures that chain is a valid number or a string representation of a number.
-  //to validate the string and verify is a number or string ("abc")=> false, ("1")=>true
-  //!isNaN is not a number? true is number. && convert the chain into number and compare if the input is the NumberCard
-  if (!isNaN(chain) && numberCards.includes(Number(chain))) {
-    return Number(chain);
-  }
+ else  if(input === "A")
+    return 11
 
-  if (chain === ace) {
-    return 11;
+  else if (
+    input.toUpperCase() === "K" ||
+    input.toUpperCase() === "Q" ||
+    input.toUpperCase() === "J"
+  ) {
+    return 10;
   }
-  //Handle Invalid Cards:
-  throw new Error("Invalid card rank."); // throw does no return values only parameter that does not include the functions
+  else return "Invalid card rank.";
+
 }
 
-console.log(IdentifyNumberCard(2));
+
+// // Test cases 
+console.log(getCardValue("10"));   // Output: 10
+console.log(getCardValue("10♠"));  // Output: 10
+console.log(getCardValue("5♥"));   // Output: 5
+console.log(getCardValue("A"));    // Output: 11
+console.log(getCardValue("k$"));   // output Invalid card rank.
+console.log(getCardValue("k"));    // output 10
+
+
+
+
+// ========================== optimized version =======================
+
+// function getCardValue(input) {
+//   const validSuits = ["♠", "♥", "♣", "♦"];
+//   const rank = input.length > 1 && isNaN(input) ? input.slice(0, -1) : input;
+//   const suit = input.length > 1 ? input.slice(-1) : null;
+
+//   // Validate suit if present
+//   if (suit && !validSuits.includes(suit)) {
+//     return "Invalid card suit.";
+//   }
+
+//   // Handle numeric cards
+//   if (rank >= 2 && rank <= 10) {
+//     return Number(rank);
+//   }
+
+//   // Handle face cards
+//   if (["K", "Q", "J"].includes(rank.toUpperCase())) {
+//     return 10;
+//   }
+
+//   // Handle Ace
+//   if (rank.toUpperCase() === "A") {
+//     return 11;
+//   }
+
+//   return "Invalid card rank.";
+// }
+
+// // Test cases
+// console.log(getCardValue("10"));    // Output: 10
+// console.log(getCardValue("10♠"));   // Output: 10
+// console.log(getCardValue("5♥"));    // Output: 5
+// console.log(getCardValue("A"));     // Output: 11
+// console.log(getCardValue("K$"));    // Output: "Invalid card suit."
+// console.log(getCardValue("K"));     // Output: 10
+// console.log(getCardValue("11♥"));   // Output: "Invalid card rank."
+
+