coursework/sprint-3-implement-and-rewrite are done

Author: shaghayeghfar

Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js

@@ -67,7 +67,7 @@ assertEquals(acute, "Acute angle");
 // Then the function should return "Obtuse angle"
 const obtuse = getAngleType(120);
 assertEquals(obtuse, "Obtuse angle");
-
+//
 // Case 4: Identify Straight Angles:
 // When the angle is exactly 180 degrees,
 // Then the function should return "Straight angle"

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -29,7 +29,7 @@ function assertEquals(actualOutput, targetOutput) {
 }
 
 // Acceptance criteria:
-
+//
 // Proper Fraction check:
 // Input: numerator = 2, denominator = 3
 // target output: true

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

@@ -69,6 +69,7 @@ assertEquals(tenofDiamonds, 10);
 // Given a card with a rank of "J," "Q," or "K",
 // When the function is called with such a card,
 // Then it should return 10
+//
 const jackofClubs = getCardValue("J♣");
 assertEquals(jackofClubs, 10);
 

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

@@ -7,6 +7,7 @@ test("should identify right angle (90°)", () => {
 });
 
 // Case 2: Identify Acute Angles
+//
 // When the angle is less than 90 degrees, it should return "Acute angle"
 test("should identify acute angle (<90°)", () => {
   expect(getAngleType(45)).toEqual("Acute angle");

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -1,13 +1,32 @@
-// This statement loads the isProperFraction function you wrote in the implement directory.
-// We will use the same function, but write tests for it using Jest in this file.
 const isProperFraction = require("../implement/2-is-proper-fraction");
 
-test("should return true for a proper fraction", () => {
+// Case 1: Proper fraction
+test("should return true for a proper fraction (numerator < denominator)", () => {
   expect(isProperFraction(2, 3)).toEqual(true);
 });
+//
 
-// Case 2: Identify Improper Fractions:
+// Case 2: Improper fraction
+test("should return false for an improper fraction (numerator > denominator)", () => {
+  expect(isProperFraction(5, 2)).toEqual(false);
+});
+
+// Case 3: Negative fraction
+test("should return true for a negative proper fraction (numerator < denominator)", () => {
+  expect(isProperFraction(-4, 7)).toEqual(true);
+});
 
-// Case 3: Identify Negative Fractions:
+// Case 4: Numerator equal to denominator
+test("should return false when numerator equals denominator", () => {
+  expect(isProperFraction(3, 3)).toEqual(false);
+});
 
-// Case 4: Identify Equal Numerator and Denominator:
+// Optional: Zero numerator
+test("should return true when numerator is zero", () => {
+  expect(isProperFraction(0, 5)).toEqual(true);
+});
+
+// Case 5: Negative denominator
+test("should return true when denominator is negative and proper", () => {
+  expect(isProperFraction(2, -5)).toEqual(true);
+});

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

@@ -28,7 +28,7 @@ test("should return 10 for face cards J, Q, K", () => {
 test("should return 11 for Ace of Hearts", () => {
   expect(getCardValue("A♥")).toEqual(11);
 });
-
+//
 // Case 5: Handle Invalid Cards
 // If the card rank is invalid, it should throw an error
 test("should throw error for invalid cards", () => {