|
35 | 35 | // This specification outlines the behavior of the isValidTriangle function for different input scenarios, ensuring it properly checks for invalid side lengths and whether they form a valid triangle according to the Triangle Inequality Theorem. |
36 | 36 |
|
37 | 37 |
|
38 | | -function isValidTriangle(side1, side2, side3){ |
| 38 | +// function isValidTriangle(side1, side2, side3){ |
39 | 39 |
|
40 | | - if(side1 === 0 || side2 === 0 || side3 === 0){ |
41 | | - return false; |
42 | | - } |
43 | | - |
44 | | - else if(side1 + side2 > side3){ |
45 | | - return true; |
46 | | - } |
47 | | - else if(side2 + side3 > side1){ |
48 | | - return true; |
49 | | - } |
50 | | - else if(side1 + side3 > side2){ |
51 | | - return true; |
52 | | - } |
53 | | - return false |
| 40 | +// if(side1 === 0 || side2 === 0 || side3 === 0){ |
| 41 | +// return false; |
| 42 | +// } |
54 | 43 |
|
| 44 | +// else if(side1 + side2 > side3){ |
| 45 | +// return true; |
| 46 | +// } |
| 47 | +// else if(side2 + side3 > side1){ |
| 48 | +// return true; |
| 49 | +// } |
| 50 | +// else if(side1 + side3 > side2){ |
| 51 | +// return true; |
| 52 | +// } |
| 53 | +// return false |
55 | 54 |
|
56 | | -} |
| 55 | +// } |
57 | 56 |
|
58 | | -console.log(isValidTriangle(3, 20, 20)); |
59 | | -console.log(isValidTriangle(3, 6, 10)); |
60 | | -console.log(isValidTriangle(9, 0, 1)); |
61 | | -console.log(isValidTriangle(5, 0, 1)); |
| 57 | +// console.log(isValidTriangle(3, 20, 20)); |
| 58 | +// console.log(isValidTriangle(3, 6, 10)); |
| 59 | +// console.log(isValidTriangle(9, 0, 1)); |
| 60 | +// console.log(isValidTriangle(5, 0, 1)); |
62 | 61 |
|
63 | 62 |
|
64 | 63 | // ========================== optimized version ======================= |
65 | 64 |
|
66 | | -// function isValidTriangle(side1, side2, side3) { |
67 | | -// // Check for non-positive side lengths |
68 | | -// if (side1 <= 0 || side2 <= 0 || side3 <= 0) { |
69 | | -// return false; |
70 | | -// } |
71 | | -// // Validate triangle inequality |
72 | | -// if (side1 + side2 > side3 && side2 + side3 > side1 && side1 + side3 > side2) { |
73 | | -// return true; |
74 | | -// } |
75 | | -// return false; |
76 | | -// } |
| 65 | +function isValidTriangle(side1, side2, side3) { |
| 66 | + // Check for non-positive side lengths or triangle inequality failure |
| 67 | + if (side1 <= 0 || side2 <= 0 || side3 <= 0 || side1 + side2 <= side3 || side2 + side3 <= side1 || side1 + side3 <= side2) { |
| 68 | + return false; |
| 69 | + } |
| 70 | + return true; |
| 71 | +} |
77 | 72 |
|
78 | | -// console.log(isValidTriangle(3, 20, 20)); // false |
79 | | -// console.log(isValidTriangle(3, 6, 10)); // true |
80 | | -// console.log(isValidTriangle(9, 0, 1)); // false |
81 | | -// console.log(isValidTriangle(5, 0, 1)); // false |
| 73 | +console.log(isValidTriangle(3, 20, 20)); // true |
| 74 | +console.log(isValidTriangle(3, 6, 10)); // false |
| 75 | +console.log(isValidTriangle(9, 0, 1)); // false |
| 76 | +console.log(isValidTriangle(5, 0, 1)); // false |
0 commit comments