Skip to content

Commit 2396b83

Browse files
committed
validate in one line the triangle inequality
1 parent bf0e4d8 commit 2396b83

File tree

1 file changed

+30
-35
lines changed

1 file changed

+30
-35
lines changed

Sprint-3/implement/is-valid-triangle.js

Lines changed: 30 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -35,47 +35,42 @@
3535
// This specification outlines the behavior of the isValidTriangle function for different input scenarios, ensuring it properly checks for invalid side lengths and whether they form a valid triangle according to the Triangle Inequality Theorem.
3636

3737

38-
function isValidTriangle(side1, side2, side3){
38+
// function isValidTriangle(side1, side2, side3){
3939

40-
if(side1 === 0 || side2 === 0 || side3 === 0){
41-
return false;
42-
}
43-
44-
else if(side1 + side2 > side3){
45-
return true;
46-
}
47-
else if(side2 + side3 > side1){
48-
return true;
49-
}
50-
else if(side1 + side3 > side2){
51-
return true;
52-
}
53-
return false
40+
// if(side1 === 0 || side2 === 0 || side3 === 0){
41+
// return false;
42+
// }
5443

44+
// else if(side1 + side2 > side3){
45+
// return true;
46+
// }
47+
// else if(side2 + side3 > side1){
48+
// return true;
49+
// }
50+
// else if(side1 + side3 > side2){
51+
// return true;
52+
// }
53+
// return false
5554

56-
}
55+
// }
5756

58-
console.log(isValidTriangle(3, 20, 20));
59-
console.log(isValidTriangle(3, 6, 10));
60-
console.log(isValidTriangle(9, 0, 1));
61-
console.log(isValidTriangle(5, 0, 1));
57+
// console.log(isValidTriangle(3, 20, 20));
58+
// console.log(isValidTriangle(3, 6, 10));
59+
// console.log(isValidTriangle(9, 0, 1));
60+
// console.log(isValidTriangle(5, 0, 1));
6261

6362

6463
// ========================== optimized version =======================
6564

66-
// function isValidTriangle(side1, side2, side3) {
67-
// // Check for non-positive side lengths
68-
// if (side1 <= 0 || side2 <= 0 || side3 <= 0) {
69-
// return false;
70-
// }
71-
// // Validate triangle inequality
72-
// if (side1 + side2 > side3 && side2 + side3 > side1 && side1 + side3 > side2) {
73-
// return true;
74-
// }
75-
// return false;
76-
// }
65+
function isValidTriangle(side1, side2, side3) {
66+
// Check for non-positive side lengths or triangle inequality failure
67+
if (side1 <= 0 || side2 <= 0 || side3 <= 0 || side1 + side2 <= side3 || side2 + side3 <= side1 || side1 + side3 <= side2) {
68+
return false;
69+
}
70+
return true;
71+
}
7772

78-
// console.log(isValidTriangle(3, 20, 20)); // false
79-
// console.log(isValidTriangle(3, 6, 10)); // true
80-
// console.log(isValidTriangle(9, 0, 1)); // false
81-
// console.log(isValidTriangle(5, 0, 1)); // false
73+
console.log(isValidTriangle(3, 20, 20)); // true
74+
console.log(isValidTriangle(3, 6, 10)); // false
75+
console.log(isValidTriangle(9, 0, 1)); // false
76+
console.log(isValidTriangle(5, 0, 1)); // false

0 commit comments

Comments
 (0)