Implement isProperFraction function

Author: saff-coder

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -1,15 +1,20 @@
 // Implement a function isProperFraction
 // Write assertions for your function to check it works in different cases
-// Terms:
+// Terms:A proper fraction is when:
+//the absolute value of the numerator is less than the denominator
+
 // Fractions: https://www.bbc.co.uk/bitesize/topics/zt9n6g8/articles/zjxpp4j
 // Written here like this: 1/2 == Numerator/Denominator
 // the first test and first case is written for you
-// complete the rest of the tests and cases
-// write one test at a time, and make it pass, build your solution up methodically
+// 1-complete the rest of the tests and cases
 
+// 2-write one test at a time, and make it pass, build your solution up methodically
+//1-
 function isProperFraction(numerator, denominator) {
-  if (numerator < denominator) {
+  if (Math.abs(numerator) < Math.abs(denominator)) {
     return true;
+  } else {
+    return false;
   }
 }
 
@@ -46,14 +51,20 @@ assertEquals(improperFraction, false);
 // target output: true
 // Explanation: The fraction -4/7 is a proper fraction because the absolute value of the numerator (4) is less than the denominator (7). The function should return true.
 const negativeFraction = isProperFraction(-4, 7);
-// ====> complete with your assertion
+assertEquals(negativeFraction, true);
+
 
 // Equal Numerator and Denominator check:
 // Input: numerator = 3, denominator = 3
 // target output: false
 // Explanation: The fraction 3/3 is not a proper fraction because the numerator is equal to the denominator. The function should return false.
 const equalFraction = isProperFraction(3, 3);
-// ====> complete with your assertion
+assertEquals(equalFraction, false);
+
+
 
 // Stretch:
 // What other scenarios could you test for?
+const negativeDenominator = isProperFraction(3, -5);
+assertEquals(negativeDenominator, true);
+const bothNegative = isProperFraction(-2, -6);