Refactor getCardValue function to use includes for number card handling

Payman IB · Payman IB · commit 4c6389a717b8 · 2025-11-23T16:12:08.000Z
diff --git a/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js b/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js
@@ -13,9 +13,9 @@ function getCardValue(card) {
   if (rank === "A") {
     return 11;
   }
-  else if ( 2 <= rank && rank <= 9 ){
-    return Number(rank);
-  }
+  else if (["2","3","4","5","6","7","8","9"].includes(rank)) {
+  return Number(rank);
+}
   else if (rank === "10" || rank === "J" || rank === "Q" || rank === "K") {
     return 10;
   }

Original file line number	Diff line number	Diff line change
`@@ -13,9 +13,9 @@ function getCardValue(card) {`
`13`	`13`	`if (rank === "A") {`
`14`	`14`	`return 11;`
`15`	`15`	`}`
`16`		`- else if ( 2 <= rank && rank <= 9 ){`
`17`		`- return Number(rank);`
`18`		`- }`
	`16`	`+ else if (["2","3","4","5","6","7","8","9"].includes(rank)) {`
	`17`	`+ return Number(rank);`
	`18`	`+}`
`19`	`19`	`else if (rank === "10" \|\| rank === "J" \|\| rank === "Q" \|\| rank === "K") {`
`20`	`20`	`return 10;`
`21`	`21`	`}`