Skip to content

Commit 5de912a

Browse files
committed
fix(sprint-2): resolve convertToPercentage errors with proper scoping and declaration
1 parent 2bf000b commit 5de912a

File tree

1 file changed

+13
-8
lines changed
  • Sprint-2/1-key-errors

1 file changed

+13
-8
lines changed

Sprint-2/1-key-errors/1.js

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,19 +2,24 @@
22

33
// Why will an error occur when this program runs?
44
// =============> write your prediction here
5+
// SyntaxError: Cannot redeclare parameter 'decimalNumber' inside function body
56

67
// Try playing computer with the example to work out what is going on
78

8-
function convertToPercentage(decimalNumber) {
9-
const decimalNumber = 0.5;
10-
const percentage = `${decimalNumber * 100}%`;
11-
12-
return percentage;
13-
}
14-
15-
console.log(decimalNumber);
9+
// function convertToPercentage(decimalNumber) {
10+
// const decimalNumber = 0.5;
11+
// const percentage = `${decimalNumber * 100}%`;
12+
// return percentage;
13+
// }
14+
// console.log(decimalNumber);
1615

1716
// =============> write your explanation here
17+
// SyntaxError: Identifier 'decimalNumber' has already been declared - parameter cannot be redeclared
18+
// Also, console.log(decimalNumber) would cause ReferenceError - variable only exists inside function scope
19+
// https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/Redeclared_parameter
1820

1921
// Finally, correct the code to fix the problem
2022
// =============> write your new code here
23+
function convertToPercentage(decimalNumber) {
24+
return `${decimalNumber * 100}%`;
25+
}

0 commit comments

Comments
 (0)