Refactor tests for getCardValue function to handle all Aces and number cards dynamically; update invalid card handling

Author: zilinskyte

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

@@ -52,14 +52,6 @@ const kingofDiamonds = getCardValue("K♦");
 assertEquals(kingofDiamonds, 10);
 
 // Case 4
-// Handle Ace (A):
-// Given a card with a rank of "A",
-// When the function is called with an Ace,
-// Then it should, by default, assume the Ace is worth 11 points, which is a common rule in blackjack.
-const aceofHearts = getCardValue("A♥");
-assertEquals(aceofHearts, 11);
-
-// Case 5
 // Handle Invalid Cards:
 // Given a card with an invalid rank (neither a number nor a recognized face card),
 // When the function is called with such a card,

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

@@ -2,31 +2,39 @@
 // We will use the same function, but write tests for it using Jest in this file.
 const getCardValue = require("../implement/3-get-card-value");
 
-test("should return 11 for Ace of Spades", () => {
-  const aceofSpades = getCardValue("A♠");
-  expect(aceofSpades).toEqual(11);
-});
+test("should return 11 for all Aces", () => {
+  const suits = ["♠", "♥", "♦", "♣"];
+  for (const suit of suits) {
+    expect(getCardValue(`A${suit}`)).toEqual(11);
+  }
+}); // One array handles all suits for Aces
 
 // Case 2: Handle Number Cards (2-10):
-test("should return 7 for 7 of Hearts", () => {
-  const sevenOfHearts = getCardValue("7♥");
-  expect(sevenOfHearts).toEqual(7);
-});
+test("should return correct value for number cards (2-10)", () => {
+ const suits = ["♠", "♥", "♦", "♣"];
+ for (let i = 2; i <= 10; i++) {
+   for (const suit of suits) {
+     expect(getCardValue(`${i}${suit}`)).toEqual(i);
+   }
+ }
+}); // Loop through numbers 2-10 for all suits; 36 test cases 
 
 // Case 3: Handle Face Cards (J, Q, K):
-test("should return 10 for King of Hearts", () => {
-  const kingOfHearts = getCardValue("K♥");
-  expect(kingOfHearts).toEqual(10);
-});
+test("should return 10 for all face cards (J, Q, K)", () => {
+  const faceCards = ["J", "Q", "K"];
+  const suits = ["♠", "♥", "♦", "♣"];
+  for (const card of faceCards) {
+    for (const suit of suits) {
+      expect(getCardValue(`${card}${suit}`)).toEqual(10);
+    }
+  }
+}); // Loop through face cards for all suits; 12 test cases
 
-// Case 4: Handle Ace (A):
-test("should return 11 for Ace of Diamonds", () => {
-  const aceOfDiamonds = getCardValue("A♦");
-  expect(aceOfDiamonds).toEqual(11);
-});
 
-// Case 5: Handle Invalid Cards:
-test("should return 0 for invalid card", () => {
-  const invalidCard = getCardValue("1♣");
-  expect(invalidCard).toEqual(0);
-});
+// Case 4: Handle Invalid Cards:
+test("should throw error for all invalid cards", () => {
+  const invalidCards = ["1♣", "11♦", "B♠", "Z♥", "15♣", "", " "];
+  for (const card of invalidCards) {
+    expect(() => getCardValue(card)).toThrow("Invalid card rank");
+  }
+}); // Loop through all invalid cards; 7 test cases