added tests for most fraction types and conditions for them as well

Author: asaniDev

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -8,14 +8,26 @@
 // write one test at a time, and make it pass, build your solution up methodically
 
 function isProperFraction(numerator, denominator) {
+  if (Math.sign(numerator) === -1 || Math.sign(denominator) === -1) {
+    if (Math.abs(numerator) < Math.abs(denominator)) {
+      return true;
+    }
+  } else if (numerator === 0) {
+    return false;
+  }
+
   if (numerator < denominator) {
     return true;
+  } else if (numerator > denominator) {
+    return false;
+  } else if (numerator === denominator) {
+    return false;
   }
 }
 
 // The line below allows us to load the isProperFraction function into tests in other files.
 // This will be useful in the "rewrite tests with jest" step.
-module.exports = isProperFraction;
+//module.exports = isProperFraction;
 
 // here's our helper again
 function assertEquals(actualOutput, targetOutput) {
@@ -45,15 +57,20 @@ assertEquals(improperFraction, false);
 // Input: numerator = -4, denominator = 7
 // target output: true
 // Explanation: The fraction -4/7 is a proper fraction because the absolute value of the numerator (4) is less than the denominator (7). The function should return true.
-const negativeFraction = isProperFraction(-4, 7);
+const negativeFraction = isProperFraction(-4, -7);
 // ====> complete with your assertion
+assertEquals(negativeFraction, true);
 
 // Equal Numerator and Denominator check:
 // Input: numerator = 3, denominator = 3
 // target output: false
 // Explanation: The fraction 3/3 is not a proper fraction because the numerator is equal to the denominator. The function should return false.
 const equalFraction = isProperFraction(3, 3);
 // ====> complete with your assertion
+assertEquals(equalFraction, false);
 
 // Stretch:
 // What other scenarios could you test for?
+//we can test if the numerator is 0
+const zeroFraction = isProperFraction(0, 4);
+assertEquals(zeroFraction, false);